change mattn/go-sqlite3 to modernc.org/sqlite #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cryptix oh sick! does everything mostly just work after applying this patch? :o personal opinion: i think it might be wiser to do a merge & deploy after coming home from yr bike adventure :~ |
|
Sounds okay by me! I don't have an opinion on this. Just try to make CI green before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell the modernc.org/sqlite transpile project came quiet a bit further, stabilised and proofed that it's much less mad science than people, me included, initially thought.
fixes #79
I will put this on hermies.club in a bit (if WifionICE allows me to). It's my understanding that this should be byte-per-byte compatible with the previous sqlite adapter and thus not need migration(s) but exhaustive testing is always in order with these things.