add test for unix-socket plugin #34
Conversation
cryptix
force-pushed
the
add/unix-sock-test
branch
from
4e49d15
to
b3b6273
Compare
|
currently based on #35 but could be untangled. |
|
https://ci.appveyor.com/project/cryptix/multiserver/builds/20982608/job/6bvvas7ifkvymhu8#L100 windows can listen but not connect, it seems. need to refresh my assumptions. still think this should be fixable. |
|
this issue looks like i need to do that chmod.. but that also gave me a ENOENT error... hmmmmm.. I'll get a windows VM later. |
|
Is this still good to go, or does it need something else before review? |
|
@christianbundy I think it's good to go but I didn't touch this since opening it. I fear I forgot all about why it acted up on windows. Still think it should be doable to run all this on the three platforms. |
|
@cryptix I had to rebase this, but merged. thanks! sorry it lingered this long. |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
|
Closing because it was already rebased onto |
I noticed there were no tests for this plugin so I added at least this one. also verifies @arj03 comment on the linked issue, that the
server:trueoption is needed.(updates ssbc/ssb-server#577)