Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shebang #4

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Remove shebang #4

merged 1 commit into from
Feb 7, 2018

Conversation

christianbundy
Copy link
Contributor

This allows the module to be used in the browser.

@dominictarr
Copy link
Contributor

this breaks it as a command, can you make a bin.js file that has the #!

This removes the shebang from index.js for browser compatibility without
breaking the command-line usage.
@christianbundy
Copy link
Contributor Author

christianbundy commented Nov 27, 2017

Done, I've moved the shebang and the if(!module.parent) to bin.js, fixed the permissions, and updated package.json with the new path. Please let me know if there's anything else, thanks for the quick review!

@cryptix
Copy link
Member

cryptix commented Feb 2, 2018

@dominictarr can we merge this please?

@dominictarr dominictarr merged commit cc1fc6b into ssbc:master Feb 7, 2018
@dominictarr
Copy link
Contributor

merged into 1.4.3

@christianbundy
Copy link
Contributor Author

Thanks!

cryptix added a commit to cryptix/scuttlebot that referenced this pull request Feb 9, 2018
See ssbc/non-private-ip#4

Also we had a tilde(~) here before instead of a carrot(^) for the version range.
cryptix added a commit to cryptix/scuttlebot that referenced this pull request Feb 9, 2018
See ssbc/non-private-ip#4

Also we had a tilde(~) here before instead of a carrot(^) for the version range.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants