Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
IPv6 addresses can have a scope
%
suffix for examplefe80::6d6:aaff:fe87:179c%wlan0
but there are two ways to use that: (1) with the interface name e.g.%wlan0
or (2) a number ID given by the operating system e.g.%4
.The second method is sometimes given by the interface details object, like:
Problem
The implementation was always adding the scope as the interface name. This could be problematic on Windows where the interface name is something like
Local Area Connection
so the scope%Local Area Connection
wouldn't work.Solution
Prioritize using
details.scopeid
if it exists, otherwise fall back to interface name.Also updates test toolkit and enables tests in CI.