Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy codebase #5

Merged
merged 4 commits into from
Apr 19, 2022
Merged

tidy codebase #5

merged 4 commits into from
Apr 19, 2022

Conversation

staltz
Copy link
Member

@staltz staltz commented Apr 19, 2022

I'm about to add a small new feature to Obz, but before that I wanted to refactor the codebase a bit so that:

  • Uses a bit of const, let
  • Avoids anonymous functions
  • Prefers nextValue naming over _value
  • Renames many to obz

@staltz staltz requested a review from arj03 April 19, 2022 07:54
arj03
arj03 approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@arj03 arj03 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@staltz staltz merged commit 835b01c into master Apr 19, 2022
@staltz staltz deleted the refactor2 branch April 19, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arj03 arj03 arj03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@staltz @arj03