Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Toggle settings with CommandOrCtrl+. #1209

Merged
merged 5 commits into from Nov 26, 2019

Conversation

jedahan
Copy link
Contributor

@jedahan jedahan commented Nov 17, 2019

Probably not the best way to do this, but it scratched an itch I had

@christianbundy
Copy link
Contributor

Is this a common standard? I'm aware of Cmd + , on macOS and I'd support that change, but I'm not familiar with binding . (or having it do both Cmd and Ctrl). Could you add some background on this change?

@jedahan
Copy link
Contributor Author

jedahan commented Nov 18, 2019

I couldn’t get that shortcut to work for some reason! I would definitely prefer , over .

@jedahan
Copy link
Contributor Author

jedahan commented Nov 24, 2019

Huh, it works now, switch to CmdOrCtrl+,

@christianbundy
Copy link
Contributor

Thanks for switching to ,. Are you using an OS where Ctrl+, is common, or are you using Cmd+,? I'd be super down for Cmd+, because it's a well-known shortcut, but I think I'd like to avoid Ctrl+, unless that's a problem that you (or others) specifically need solved.

What do you think?

@jedahan
Copy link
Contributor Author

jedahan commented Nov 26, 2019

I'm using linux, and I think its a free-for-all but Cmd (meta) is not common but Ctrl is.

@jedahan
Copy link
Contributor Author

jedahan commented Nov 26, 2019

It might be worth looking at KDE, Gnome, XFCE, Pantheon, i3, fvwm, etc and try and follow their HIGs or our best guess at what a) does not conflict and b) seems to fit after detecting which DE/WM someone is using. For now I think this is an okay incremental improvement.

@christianbundy
Copy link
Contributor

Looks great to me, merging now!

@christianbundy christianbundy merged commit 5824494 into ssbc:master Nov 26, 2019
@jedahan jedahan deleted the toggle-settings-shortcut branch November 26, 2019 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants