This repository has been archived by the owner on May 12, 2021. It is now read-only.
Feature: Localize timestamps and "time ago" with moment #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
%2fV/5OP/V6ttz5K4YrvUw2TsL/L0W0JEUXX2y/no7U4=.sha256
This removes the internal timeAgo and uses moment's localized fromNow. It also shows the tooltip timestamp localized as moment.format('LLLL zz') with the chosen language in the settings. This branches off @ahdinosaurs prior art in #1206 and implements it across the codebase. Also removes the human-time requirement.
|
Oh wow, what a great PR! I'm very happy to merge this. Thanks a bunch for this improvement! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the requirement for the internal "timeAgo" calls and
human-time- which are both superseded by moment's internal localization. The locale and default timezone are now set globally frommain-window.js. This dovetails off of @ahdinosaur 's prior art in #1206 and implements it across the codebase using the user-selected language.Feature request was originally from:
%2fV/5OP/V6ttz5K4YrvUw2TsL/L0W0JEUXX2y/no7U4=.sha256Changes:
To:
And for gatherings it now shows:
