Ensure that msg.value is truthy

[christianbundy]

Resolves #882

---

This resolves and edge-case where a message is being passed to checkBump. I'm unclear on why this is necessary, as sbot seems to be reporting that the message doesn't exist, but it should resolve the bug.

cc: @smowafy could you test this and let me know if it resolves the issue?

[smowafy]

@christianbundy yea this works locally, but I want to make sure I understand correctly.

I opened #software channel now and I can't find the message we mentioned in the issue. So either I receive the message without the value option or it lost it along the way. Am I correct?

I'm not aware of the internals and I'm actually interested to know the root cause of this. Also thanks a lot for your time checking this issue!

[christianbundy]

No problem! My best guess is that you don't have those messages because @O71isksx77Du8JQvsf91sdPwW4kPnlZgnw8IotOYxlM=.ed25519 isn't someone within your follow range, but that you only have the replies to that message. Each reply specifies the parent message, so I think the client likely tried to render the parent message without actually checking to see if it's a message you have. For reference, here's how the thread looks for me:

You're missing the root message, but my guess is that Dominic is within your follow range, so when Patchwork tried to render the thread it crashed when it assumed it had the entire thread. It could totally be something else, but that's the best explanation I can come up with.

cc: @mmckegg does that sound right? or is there a better way to do this?