Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oldSecrets field to add-member #33

Merged
merged 3 commits into from
May 9, 2023
Merged

Add oldSecrets field to add-member #33

merged 3 commits into from
May 9, 2023

Conversation

Powersource
Copy link
Collaborator

@Powersource Powersource commented May 5, 2023

Based on #32 (merge that one first)

For ssbc/ssb-tribes2#106

  • update readme

Comment on lines +36 to +40
oldSecrets: {
type: 'array',
items: [{ $ref: '#/definitions/secret' }],
minItems: 0
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mixmix would it make sense to instead put this in the epoch inits? would save a lot of repetition, but would make initial replication of a group slower

(ps our meeting notes for reference ssbc/ssb-tribes2#76 (comment) )

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might have to add some special logic in tribes2 for this though which would mean more coding

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a bad idea... but would rather not right now - the problem is that the group/init doesn't necessarily know about all past epochs.... oh, well it does actually, just not the parallel ones.

There might be a problem with how many keys you could add to a new init.
I kinda like the idea the more I think about it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is coded already and it's not too bad I'm gonna put this in this "stuff we could maybe do if we have more time" issue ssbc/ssb-group-exclusion-spec#30 and just merge

Copy link
Member

@mixmix mixmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up to you if you want to mutate this or the group/init.

I don't know what the implications of replicating epochs in a funny order would be... note that we need to know all the people who started the epochs too to be able to replicate them D:

Base automatically changed from groupkey-to-secret to master May 9, 2023 09:25
@Powersource Powersource merged commit e73f784 into master May 9, 2023
1 check passed
@Powersource Powersource deleted the old-secrets branch May 9, 2023 09:35
@Powersource
Copy link
Collaborator Author

v8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants