Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove plugins? #198

Closed
dominictarr opened this issue Jun 26, 2015 · 6 comments
Closed

remove plugins? #198

dominictarr opened this issue Jun 26, 2015 · 6 comments

Comments

@dominictarr
Copy link
Contributor

The only thing we actually use the pluggable nature of the plugins for is removing some functionality during a test... I'm thinking that maybe "plugins" isn't the right way to think about these

@pfrazee
Copy link
Contributor

pfrazee commented Jun 26, 2015

Im a bit indifferent.

Removing plugins would simplify the manifest construction

If we could get away from the internal events-system, I'd be happier
(events control-flow is more difficult than function call)

@dominictarr
Copy link
Contributor Author

@pfraze do you mean the transmitted events? (there is only "done" and blobs uses 2 events)

just tabling it for now really, I'm not sure, I just don't feel that "plugin" is a clean abstraction.

@dominictarr
Copy link
Contributor Author

actually not sure that "plugin" is ever a clean abstraction?

@pfrazee
Copy link
Contributor

pfrazee commented Jun 26, 2015

@dominictarr no, I'm referring to the internal events system. It'd be easier to know, for instance, what happens on a new connection if we called out to plugin methods instead of having the plugins register handlers

though we still need to secure that networked emit

@dominictarr
Copy link
Contributor Author

@pfraze got it. yeah I'm just gonna kill the muxrpc emit, because the permissions system is otherwise good enough right now.

@stale
Copy link

stale bot commented Nov 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 1, 2018
@stale stale bot closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants