Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: proto.server is not a function #577

Closed
cryptix opened this issue Nov 23, 2018 · 5 comments
Closed

TypeError: proto.server is not a function #577

cryptix opened this issue Nov 23, 2018 · 5 comments
Labels

Comments

@cryptix
Copy link
Member

cryptix commented Nov 23, 2018

ssb-electron-chroot-chrootenv:cryptix@crypdesk:~/scuttle-shell$ npm start

> scuttle-shell@0.1.3 start /home/cryptix/scuttle-shell
> node server.js

started sbot server v13.1.0
scuttle-shell got exit: { code: 0, signal: null }
/home/cryptix/scuttle-shell/node_modules/multiserver/compose.js:96
      return asyncify(proto.server(function (stream) {
                            ^

TypeError: proto.server is not a function
    at Object.server (/home/cryptix/scuttle-shell/node_modules/multiserver/compose.js:96:29)
    at /home/cryptix/scuttle-shell/node_modules/multiserver/index.js:31:21
    at Array.map (<anonymous>)
    at Object.server (/home/cryptix/scuttle-shell/node_modules/multiserver/index.js:30:26)
    at Immediate.setupMultiserver [as _onImmediate] (/home/cryptix/scuttle-shell/node_modules/secret-stack/index.js:173:21)
    at runCallback (timers.js:810:20)
    at tryOnImmediate (timers.js:768:5)
    at processImmediate [as _immediateCallback] (timers.js:745:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! scuttle-shell@0.1.3 start: `node server.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the scuttle-shell@0.1.3 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/buttEnv-npm-cache/_logs/2018-11-23T21_11_18_739Z-debug.log

inserting a console.log(proto) before the return gives me:

{ name: 'unix',
  scope: [Function: scope],
  server: null,
  client: [Function: client],
  parse: [Function: parse],
  stringify: [Function: stringify] }

do we need to change this maybe? https://github.com/ssbc/scuttlebot/blob/d1cec64cc29c4dca784cf7c8cdf897f9b4f724d8/plugins/unix-socket.js#L9 I'll try to add a listen / dial test soon.

@cryptix
Copy link
Member Author

cryptix commented Nov 23, 2018

cc @arj03

@arj03
Copy link
Member

arj03 commented Nov 24, 2018

Unix socket currently needs a: "server": true option. This is part of dominics recent changes. I'm not sure why. See this where I was asking for an update to ssb-config for the new options.

@christianbundy
Copy link
Contributor

Did that change come from ssbc/multiserver#32?

cc: @dominictarr

@cryptix
Copy link
Member Author

cryptix commented Dec 13, 2018

Unix socket currently needs a: "server": true option.

thanks @arj03! also noticed that there is no test for unix-sock in multiserver, adding one now.

@arj03
Copy link
Member

arj03 commented Mar 3, 2019

Closed by multiserver 3.3.0

@arj03 arj03 closed this as completed Mar 3, 2019
dominictarr pushed a commit to ssbc/multiserver that referenced this issue Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants