-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove flumeview-query/links fork #4
Comments
It was always my intention to do these changes as a PR, but I couldn't figure out an elegant way to merge this into the existing I'm really not interested in bikeshedding an API so I don't want to discuss how to implement this as options in Here's what would need to be added to
|
At the very least, you should post an issue to let me know you are doing this. why does it return the original item? |
This module is used to retrieve related messages. If it didn't return the original item, the client code would need to perform a second lookup to get the actual item. Why not just return it as part of the index? It could be an option like How do you think we should implement the |
I am very disapointed that the contents of the lib folder is copy pasted from flumeview-query.
Why didn't you make a PR? copying my code might save you time one day, but it means you are now maintaining my code, and since you didn't even post an issue, I didn't even know where doing this until I read the code because of the forks discussion. You are just creating more work for yourself and making my work less effective!
The text was updated successfully, but these errors were encountered: