Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect replication progress that are compatible with patchwork #1

Closed
dominictarr opened this issue Apr 4, 2017 · 3 comments
Closed
Labels

Comments

@dominictarr
Copy link
Contributor

@mmckegg I'm trying to figure out how to make this support progress bars.
in EBT we have details of where we and our peer are up to somewhat more reliably,
so we can easily figure out exactly how many messages are missing, how many feeds not complete yet, both to send and to receive.

Looking at your code, the part I'm having figuring out is pendingFeedsPerPeer is that an object of peers you are currently connected to, pointing to counts of the feeds which are not complete on that particular peer?

are the peer ids used later in patchwork? or are they reduced to a number?

@mmckegg
Copy link
Contributor

mmckegg commented Apr 5, 2017

@dominictarr yeah, looks like pendingFeedsForPeer is indeed reduced to a number.

The mechanism doesn't matter but what we need to get out of progress is:

  • the current sync progress for every connected peer (how far are we through the sync progress)
  • the total number of feeds that are pending download (how many feeds are not up to date? Ideally only ones available from connected peers, otherwise the progress will appear to stall)

Currently peer sync progress is just the number of feeds that are still waiting to sync. But this could be changed to a percentage of completion if that's easier to figure out with EBT.

@dominictarr
Copy link
Contributor Author

great - yeah we can do those things quite easily, instead of the awkward stuff we have to do in the old way (and hope and pray)

@stale
Copy link

stale bot commented Nov 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 1, 2018
@stale stale bot closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants