replace continuables with async-await in tests #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, quite a PR. Overall from first look, this is a very nice cleanup. |
arj03
reviewed
Jun 14, 2021
arj03
reviewed
Jun 14, 2021
arj03
reviewed
Jun 14, 2021
arj03
reviewed
Jun 14, 2021
arj03
reviewed
Jun 14, 2021
arj03
reviewed
Jun 14, 2021
arj03
reviewed
Jun 14, 2021
arj03
reviewed
Jun 14, 2021
arj03
reviewed
Jun 14, 2021
arj03
reviewed
Jun 14, 2021
|
I ended up reading all the tests in the new version. They are actually quite readable now. Great job cleaning this up! |
arj03
reviewed
Jun 15, 2021
|
@arj03 Check my latest commit, I think it should fully clarify |
|
Yep. This is really great. I now want to start using ssb-ebt again in browser-core after reading these tests :) |
|
Can I green? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new async-await control flow makes tests easier to read, since they are sequential (but still allow parallelism via
Promise.all), a developer reading code doesn't have to jump their eyes up and down trying to follow the flow, and there's no callback pyramid.In some cases I rewrote the tests, because they either didn't assert anything, or were using inconsistent patterns (it seems like some test files used one way of connecting, while other files used another method, seems to be that one method was an old style).
A big PR, but I feel confident about these tests are now readable and deterministic (don't rely on console.logs to do "human assertion").