Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbermuda #45

Merged
merged 18 commits into from
Jun 28, 2021
Merged

Unbermuda #45

merged 18 commits into from
Jun 28, 2021

Conversation

staltz
Copy link
Member

@staltz staltz commented Jun 15, 2021

  • Remove legacy
  • Move some integration tests to ssb-replication-scheduler
  • >=95% test coverage
  • Test in production
  • Update readme.md

@staltz staltz marked this pull request as draft June 15, 2021 14:59
@staltz staltz marked this pull request as ready for review June 22, 2021 10:33
Copy link
Member

@mixmix mixmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a very shallow review. Did not read tests, did not visit read logic.
Mainly read readme for clarity

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
test/block.js Outdated Show resolved Hide resolved
test/resync.js Outdated Show resolved Hide resolved
Copy link
Member

@arj03 arj03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things. Fantastic work on this. Net +500 lines removed 🔥

@arj03
Copy link
Member

arj03 commented Jun 24, 2021

This is not for this PR to fix, but one thing that I find confusing about this module is that it has request and block and those 2 have to be called correctly to represent what is 3 states: follow, base, block.

@staltz
Copy link
Member Author

staltz commented Jun 26, 2021

This is not for this PR to fix, but one thing that I find confusing about this module is that it has request and block and those 2 have to be called correctly to represent what is 3 states: follow, base, block.

I agree, I think it was dictated by e-b-t's API with events.follow(state, {id, value}) and events.block(state, {id, target, value}).

@staltz
Copy link
Member Author

staltz commented Jun 28, 2021

Can I get some thumbs ups to merge this and release version ssb-ebt@7.0.0?

@staltz staltz merged commit a1d0c41 into master Jun 28, 2021
@staltz staltz deleted the unbermuda branch June 28, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants