-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbermuda #45
Conversation
staltz
commented
Jun 15, 2021
•
edited
Loading
edited
- Remove legacy
- Move some integration tests to ssb-replication-scheduler
- >=95% test coverage
- Test in production
- Update readme.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave this a very shallow review. Did not read tests, did not visit read logic.
Mainly read readme for clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor things. Fantastic work on this. Net +500 lines removed 🔥
This is not for this PR to fix, but one thing that I find confusing about this module is that it has request and block and those 2 have to be called correctly to represent what is 3 states: follow, base, block. |
I agree, I think it was dictated by e-b-t's API with |
Can I get some thumbs ups to merge this and release version |