fix if condition to trigger the glues #61
Conversation
index.js
Outdated
| @@ -57,10 +57,10 @@ exports.init = function (sbot, config) { | |||
| const legacy = _legacy(layered) | |||
|
|
|||
| // glue modules together | |||
| if (config.friends && config.friends.hookAuth !== false) | |||
| if (!config.friends || config.friends.hookAuth !== false) | |||
There was a problem hiding this comment.
I think what you wanted to write here was just
if (config.friends.hookAuth !== false)
but you had to protect against config.friends being undefined.
The correct way is if (!config.friends || because we want the default to be "run the glue", even if config.friends is undefined.
There was a problem hiding this comment.
Ah, default values. Right. Hmm, I just find these kind of logic expressions hard to read.
There was a problem hiding this comment.
That is a good find, I was a breaking change before...
There was a problem hiding this comment.
maybe // default: true comment on this line?
There was a problem hiding this comment.
Fun fact: ?. optional chaining and ?? nullish coalescing are already standardized, supported in all green browsers, and supported in Node.js 14:
var a = {}
console.log(a?.foo?.bar ?? 'yo')
// 'yo' Sometime in the next few years we can start using it to create defaults.
| friends: { | ||
| hookAuth: false, | ||
| hookReplicate: false | ||
| }, |
There was a problem hiding this comment.
These changes are required because the tests were relying on the glue code not running (because we don't have ssb-replicate installed, which the glues need). So here we have to opt-out.
|
@arj03 Ready for another look. |
I think this is what is causing ssb-ebt tests to break, because ssb-ebt tests don't specify
config.friendsand then the glues were not running.