branchStream can be called immediately after findOrCreate #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arj03
reviewed
Nov 7, 2022
arj03
reviewed
Nov 7, 2022
|
Just one minor thing, the rest looks good and great way to simplify the usage of this module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Tests were failing downstream in ssb-tribes2 when I created a groupFeed and then tried to use branchStream to replicate that to other peers.
Problem
After findOrCreate, branchStream had to "wait" for the ssb-db2 bendybutt message to be processed and then converted to a "details" object.
If you called branchStream immediately after findOrCreate was done, this means you would miss the newly-created leaf feed.
Solution
As soon as findOrCreate is done,
updateLookupon the branchStream logic so that the data is synchronously available there.1st ❌ 2nd ✔️