add ability to skipMainFeed connection #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here it is in |
|
Profiling shows that it takes about 500ms to announce the root on the main, but it takes 1600ms to create |
|
I think all of these waits are coming from lodash.debounce which is sprinkled around in ssb-db2 and async-append-only-log. In some tests we have disabled those timers so that tests run quicker. |
|
Can we close this PR? @mixmix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
ssb-tribes2test suite was taking 3min 40s to run on my desktop. I did a little analysis and found that there was sometimes significant slow-downs callingssb.metafeeds.findOrCreate, in particular thessb.tribes.start()seems to take 3 seconds to complete (and it creates locks).Improvement
I noticed that unless we were testing persistence, setting up the
mainfeed (publishing the rootMetaFeedId, and setting themainfeed up in a shard...) is slow, and not actually useful for most tests.I experimented with extracting that step and making it possible to turn it off.