metafeed/announce is signed by meta feed #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I should probably update validation to check these sigs. |
Oh well actually So this PR is ready to go I guess |
|
Or hey I can just make a new function, |
arj03
reviewed
Sep 14, 2021
arj03
reviewed
Sep 14, 2021
| @@ -123,7 +123,7 @@ test('seed', (t) => { | |||
| }) | |||
|
|
|||
| test('announce', (t) => { | |||
| messages.getContentAnnounce(metafeedKeys.id, (err, content) => { | |||
| messages.getContentAnnounce(metafeedKeys, (err, content) => { | |||
There was a problem hiding this comment.
There must have been a bug here before?
There was a problem hiding this comment.
Yes there was. The checking is done correctly in test/messages.js but in this file we want to test the query APIs so we just used getContentAnnounce to create the inputs, but we didn't validate the input. Anyway whatever :)
arj03
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue ssbc/ssb-meta-feeds-spec#27