update to ssb-db2 version 5.0.0 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staltz
commented
Jul 26, 2022
| @@ -23,29 +23,30 @@ | |||
| "pull-cat": "^1.1.11", | |||
| "pull-notify": "^0.1.1", | |||
| "pull-stream": "^3.6.14", | |||
| "ssb-bendy-butt": "~0.12.5", | |||
There was a problem hiding this comment.
This is now just a feed format that has to be installed as an attachment on ssb-db2, so ssb-meta-feeds doesn't import it directly.
arj03
reviewed
Jul 26, 2022
| ) { | ||
| if (feedformat !== 'classic' && feedformat !== 'bendybutt-v1') { | ||
| throw new Error('Unknown feed format: ' + feedformat) | ||
| optsForAddDerived(mfKeys, feedpurpose, seed, feedFormat, metadata) { |
There was a problem hiding this comment.
Couldn't derived also be buttwoo now?
There was a problem hiding this comment.
Totally fine that this one of just a 1 to 1 of existing functionality
There was a problem hiding this comment.
Yeah, let's do a PR for buttwoo too, so we can add tests for it
arj03
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The git diff is net negative :) probably because we don't need
getLatestanymore.