testbot + group non-atomic tests #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixmix
commented
Sep 21, 2022
test/messages.test.js
Outdated
|
|
||
| let tombstoneMsg | ||
| let addMsg | ||
| // NOTE - these subtests are not "atomic" - db state is shared between them |
There was a problem hiding this comment.
This diff is annoying. I didn't touch the tests at all other then indenting them, and changing to t.test
Note the shared variables and sbot are now "inside" a test scope (not global in the file)
|
I'm confused with what happened to all these PRs. I approved my PR-of-your-PR, but apparently you had changed its base to become a PR-to-master, and now we have these commits in master branch: But then this PR also has those two commits, plus a git conflict. Also PR #75 has a git conflict. And why was #73 closed? What's going on?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we weren't using the testbot everywhere. Changed that to main maintenance easier.
I also considered making all test atomic so the repo was consistent, but the remaining tests were too fidey to do this with - instead I just modified the structure to make it very clear that tests depend on one another
t.testto provide a clear scopet.onlywork because starting sbots in the global scope meanst.onlywas never exiting 😠