New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sugary findAndTombstone #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit fdf2c98 Merge: 1663678 fbe1e39 Author: mixmix <mix@protozoa.nz> Date: Tue Sep 27 13:52:33 2022 +1300 Merge branch 'auto-shard' of github.com:ssbc/ssb-meta-feeds into auto-shard commit 1663678 Merge: fd31fb1 70527d5 Author: mixmix <mix@protozoa.nz> Date: Tue Sep 27 13:52:11 2022 +1300 Merge branch 'atomic-tests-cb-persist' into auto-shard commit 70527d5 Merge: 375bd22 8c9f464 Author: mixmix <mix@protozoa.nz> Date: Tue Sep 27 13:51:02 2022 +1300 Merge branch 'atomic-tests-cb-testbot' into atomic-tests-cb-persist commit 8c9f464 Merge: 8ef1d0e 0e7a624 Author: mixmix <mix@protozoa.nz> Date: Tue Sep 27 13:49:38 2022 +1300 Merge branch 'master' of github.com:ssbc/ssb-meta-feeds into atomic-tests-cb-testbot commit fbe1e39 Author: Andre Staltz <andre@staltz.com> Date: Wed Sep 21 14:18:03 2022 +0300 remove a code comment from api.js commit fe51f97 Author: Andre Staltz <andre@staltz.com> Date: Wed Sep 21 14:12:15 2022 +0300 remove a code comment from lookup.js commit fd31fb1 Author: mixmix <mix@protozoa.nz> Date: Wed Sep 21 16:18:40 2022 +1200 tidy commit 4cad7a8 Author: mixmix <mix@protozoa.nz> Date: Wed Sep 21 14:13:56 2022 +1200 cover recps case, update README commit 8ef1d0e Author: mixmix <mix@protozoa.nz> Date: Wed Sep 21 12:25:43 2022 +1200 use testbot everywhere, group non-atomic tests commit de10af1 Merge: 4e5accf 375bd22 Author: mixmix <mix@protozoa.nz> Date: Wed Sep 21 11:44:44 2022 +1200 Merge branch 'atomic-tests-cb-persist' into auto-shard commit 4e5accf Author: mixmix <mix@protozoa.nz> Date: Wed Sep 21 11:40:38 2022 +1200 fixup commit 375bd22 Author: mixmix <mix@protozoa.nz> Date: Wed Sep 21 11:21:36 2022 +1200 add persistence tests to api commit 13a0f22 Author: Andre Staltz <andre@staltz.com> Date: Tue Sep 20 11:15:33 2022 +0300 revert promise tests to cb tests commit 8267fa8 Author: mixmix <mix@protozoa.nz> Date: Tue Sep 20 17:33:45 2022 +1200 fixup commit ed72484 Author: mixmix <mix@protozoa.nz> Date: Tue Sep 20 17:28:01 2022 +1200 split out Advanced API to unclutter the README commit 4409661 Author: mixmix <mix@protozoa.nz> Date: Tue Sep 20 17:18:29 2022 +1200 fixups commit 6d4313c Author: mixmix <mix@protozoa.nz> Date: Wed Sep 14 17:10:01 2022 +1200 test that shard-feed is created in correct place commit ba96d7f Author: mixmix <mix@protozoa.nz> Date: Wed Sep 14 16:44:11 2022 +1200 add API which auto-shards commit e4cb0c8 Author: mixmix <mix@protozoa.nz> Date: Tue Sep 20 16:54:41 2022 +1200 make tests atomic, add persistence tests
staltz
reviewed
Sep 27, 2022
staltz
reviewed
Sep 27, 2022
staltz
reviewed
Sep 27, 2022
staltz
reviewed
Sep 27, 2022
staltz
reviewed
Sep 27, 2022
staltz
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted a high level API to match out high level create.
This is what I came up with