Fix ooo.get({ id, meta: true }) #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this function wasn't checking the `meta` property, which ssb-db uses to determine whether it should output `data` or `data.value` without the `key` property. This was causing very strange behavior in clients that depend on `get()` because this module hooks into ssb-db's `get()` method, so it's important that ssb-ooo provides the same behavior.
|
Looks good 👍 |
|
Thanks @arj03! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this function wasn't checking the
metaproperty, whichssb-db uses to determine whether it should output
dataordata.valuewithout the
keyproperty. This was causing very strange behavior inclients that depend on
get()because this module hooks into ssb-db'sget()method, so it's important that ssb-ooo provides the same behavior.This has haunted me for months.
Resolves #9