Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRETTY EVERYTHING #100

Merged
merged 1 commit into from
Apr 20, 2023
Merged

PRETTY EVERYTHING #100

merged 1 commit into from
Apr 20, 2023

Conversation

mixmix
Copy link
Member

@mixmix mixmix commented Apr 20, 2023

noticed prettify was only running on some files. Fixed the globs yo

@@ -77,8 +77,8 @@
"test:only": "if grep -r --exclude-dir=node_modules --exclude-dir=.git --color 'test\\.only' ; then exit 1; fi",
"test:bail": "npm run test:raw | tap-arc --bail",
"test": "npm run test:raw | tap-arc && npm run test:only",
"format-code": "prettier --write \"*.js\"",
"format-code-staged": "pretty-quick --staged --pattern \"*.js\"",
"format-code": "prettier --write \"**/*.js\"",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this jank

@mixmix
Copy link
Member Author

mixmix commented Apr 20, 2023

I'm not sure what I hate more - prettier or inconsistent formatting 😢

@mixmix mixmix requested a review from Powersource April 20, 2023 04:36
@mixmix
Copy link
Member Author

mixmix commented Apr 20, 2023

https://www.npmjs.com/package/prettier-standard

@staltz
Copy link
Member

staltz commented Apr 20, 2023

LGTM - reviewed from the toilet 🚽

@Powersource Powersource merged commit fb01925 into master Apr 20, 2023
@Powersource Powersource deleted the pReTTy branch April 20, 2023 12:34
@mixmix
Copy link
Member Author

mixmix commented Apr 20, 2023

WHO MERGED MY PR

😢 💩 👹

it's good, I like not having to come back to mini-PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants