Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin ssb-meta-feeds #60

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Unpin ssb-meta-feeds #60

merged 1 commit into from
Feb 13, 2023

Conversation

arj03
Copy link
Member

@arj03 arj03 commented Feb 13, 2023

... and add workaround in replicate to better simulate real EBT.

This should now work. A bit hacky. Might need ssbc/ssb-meta-feeds#118 to work. This is working locally with that patch.

Should fix #48

@Powersource
Copy link
Collaborator

@arj03 Nice that we have a fix! But will we be able to remove the hack later?

@arj03
Copy link
Member Author

arj03 commented Feb 13, 2023

If we used ssb-replication-scheduler instead of this replicate hack then yes ;)

Copy link
Member

@staltz staltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang, pretty deep. LGTM

Copy link
Collaborator

@Powersource Powersource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels wrong to add a hack/rely on a complex module that's supposed to be optional (repl. scheduler) but i guess this needs to be updated

@arj03 arj03 merged commit ea5e29a into master Feb 13, 2023
@arj03 arj03 deleted the unpin-ssb-meta-feeds branch February 13, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin meta-feeds version
3 participants