speed up request step for replicate #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the gains are really in tests where you replicate multiple times.... I feel like it was making a big different in my branch, but maybe not |
|
We've already had a few bugs in this file before so I'm a bit afraid of increasing the complexity of it. In your opinion is the 10s gain worth it? |
|
no I was hoping it had made more difference. I think lets close this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies replicate helper in tests to remove redundent 200ms waits (and redundent streaming of meta feeds if not needed)
Test suite times on my desktop:
BEFORE: 264.968 s
AFTER: 252.572 s
FML