Allow excluding people in large groups #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
|
reviewing now |
mixmix
reviewed
Apr 18, 2023
index.js
Outdated
Comment on lines
250
to
259
| const done = multicb() | ||
| chunk(remainingMembers, 15).forEach((membersToAdd) => { | ||
| addMembers(groupId, membersToAdd, {}, done()) | ||
| }) | ||
| done((err) => { | ||
| // prettier-ignore | ||
| if (err) return cb(clarify(err, "Couldn't re-add remaining members when excluding members")) | ||
|
|
||
| return cb() | ||
| }) |
There was a problem hiding this comment.
We can do this will pull-streams. This has a couple advantages:
- we aren't introducing an new module
- we can control the rate of publishing of these messages (yours could try publishing a lot of messages all at once and trigger a lot of tangle calculations in parallel)
Suggested change
| const done = multicb() | |
| chunk(remainingMembers, 15).forEach((membersToAdd) => { | |
| addMembers(groupId, membersToAdd, {}, done()) | |
| }) | |
| done((err) => { | |
| // prettier-ignore | |
| if (err) return cb(clarify(err, "Couldn't re-add remaining members when excluding members")) | |
| return cb() | |
| }) | |
| pull( | |
| pull.values(chunk(remainingMembers, 15)), | |
| pull.asyncMap((members, cb) => addMembers(groupId, members, {}, cb)), | |
| pull.collect((err) => { | |
| // prettier-ignore | |
| if (err) return cb(clarify(err, "Couldn't re-add remaining members when excluding members")) | |
| return cb() | |
| }) | |
| }) |
mixmix
requested changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70