-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt listMembers to exclusion and test it #95
Conversation
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
🚮 Removed packages: ssb-crut@4.6.3 |
"request review" meaning more like i have questions pls reply |
…nto refactor_epoch
refactor epochs to consolidate getPreferredEpoch
@Powersource I merged my refactor in (after putting README in, and the shape of the data coming out of |
) | ||
) | ||
cb(null) | ||
startListeners(ssb, getPreferredEpoch, console.error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BOOM, look at this cute lil guy. Tidies up a whole mess.
Also takes an error-handler at the end, so we can easily decide what we wanna do with those errors later and change this in one place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woo nice
Finally... I found a limitation which is causing that test to fail. |
preferredEpoch (live) now emits on membership updates
ssb.box2.addGroupInfo( | ||
groupId, | ||
{ key: epochInfo.secret }, | ||
(err) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is unlikely to be needed here, we would need to have already added the epoch secret to figure out that the epoch is preferred i think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but doesn't technically hurt and we'll be poking around here more later
who's even reviewing this anymore lol? i'll just merge now lmao |
Fixes #77