Use SSB-Validation-Dataset

Problem: Maintaining one validation dataset per module means that we
can't build the dataset collaboratively and the validation dataset tends
toward stagnation.

Solution: Use a collaborative validation dataset, which provides a
handful of new and interesting test failures. This branch includes eight
new failing tests that we should aim to resolve.

package.json

@@ -19,6 +19,7 @@
     "flumelog-offset": "^3.0.3",
     "pull-stream": "^3.6.0",
     "ssb-client": "^4.5.0",
+    "ssb-validation-dataset": "^1.1.0",
     "tape": "^4.6.3"
   },
   "scripts": {

test/data.js

@@ -2,28 +2,37 @@
 var tape = require('tape')
 var v = require('../')
 
-var data = require('./data/test_messages.json')
-data.forEach(function (e,i) {
-  if(e.valid)
-    tape('test valid message:'+i, function (t) {
-      var state = {feeds: {}, queue: []}
-      state.feeds[e.msg.author] = e.state
-      t.equal(v.id(e.msg), e.id)
-      v.append(state, e.cap, e.msg)
+var data = require('ssb-validation-dataset')
+
+const isObject = (subject) => typeof subject === 'object' && subject != null && Array.isArray(subject) === false
+
+data.forEach(function (e, i) {
+  var state = { feeds: {}, queue: [] }
+  if (isObject(e.message)) {
+    state.feeds[e.message.author] = e.state
+  }
+  if (e.valid) {
+    tape(`Message ${i} is valid`, function (t) {
+      try {
+        t.equal(v.id(e.message), e.id)
+        v.append(state, e.hmacKey, e.message)
+      } catch (err) {
+        console.log(e)
+        t.fail(err)
+      }
       t.end()
     })
-  else
-    tape('test valid message:'+i, function (t) {
-      var state = {feeds: {}, queue: []}
-      state.feeds[e.msg.author] = e.state
+  } else {
+    tape(`Message ${i} is invalid: ${e.error}`, function (t) {
+      var state = { feeds: {}, queue: [] }
+      if (isObject(e.message)) {
+        state.feeds[e.message.author] = e.state
+      }
       t.throws(function () {
-        try {
-          state = v.append(state, e.cap, e.msg)
-          console.log(e)
-        } catch(err) {
-          throw err
-        }
+        state = v.append(state, e.hmacKey, e.message)
+        console.log(e)
       })
       t.end()
     })
+  }
 })