Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback speed and quality indicator bugs #207

Open
sschueller opened this issue Jul 5, 2020 · 2 comments
Open

Playback speed and quality indicator bugs #207

sschueller opened this issue Jul 5, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@sschueller
Copy link
Owner

sschueller commented Jul 5, 2020

There appear to be a few bugs:

  • Change in video speed does not update the checkmark until the fragment is completely closed.
  • Change in video speed the current selection is no updated until the fragment is completely closed.
  • Change in video quality the current selection is no updated until the fragment is completely closed.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Poslovitch
Copy link
Contributor

Poslovitch commented Jul 5, 2020

  • Change in video speed the current selection is no updated until the fragment is completely closed.
  • Change in video quality the current selection is no updated until the fragment is completely closed.

I have noticed these two but could not find a fix for them. This likely has to do with how Fragments work: the "text" is generated in the onCreateView() which is seemingly not called after the overlaying fragment is closed. I don't know if there's a method in Android that'd be called when a view comes back at the "top layer" of the screen. I haven't read docs about that yet.

  • Change in video speed does not update the checkmark until the fragment is completely closed.

As far as I am aware, this bug occurred prior to the merge of #204. Like the previous two bugs, I could not find a fix as I'm not used to how fragments work on Android. This will require me to read some docs or that someone else can come with a fix.

@sschueller
Copy link
Owner Author

ok, I will take a look. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants