-
-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add Support for ECDSA Host- and Private-Keys #489
Conversation
ec792cf
to
7464e54
Compare
66c26e4
to
0002723
Compare
According to https://docs.microsoft.com/de-de/dotnet/api/system.security.cryptography.cngkey .NET Core should be also possible. But in my setup it keeps complaining it cannot find System.Security.Cryptography. Any hints? |
I think they moved it for core in to Nuget package
https://www.nuget.org/packages/System.Security.Cryptography.Algorithms/
Sent from my iPhone
… On Nov 27, 2018, at 4:11 AM, Stefan Rinkes ***@***.***> wrote:
System.Security.Cryptography
|
00994ac
to
3d3a407
Compare
.NET 3.5 Tests fail with:
|
Added an own version of the Workaround mentioned in the stackoverflow-Post. |
This is great that some additional private key support is being added. For what its worth, I'm currently working on adding ed25519 support though I'm a ways off as I don't a lot of time to work on it (currently have working code to parse openssh v1 key and decrypt it if protected with a passphrase but that's it so far). |
Cool! I'm also on it. Can you share your result so far? |
@darinkes sure, please give me a little time to clean up my code and I'll be happy to share it (It is pretty messy at the moment, I was in trial and error mode expecting to clean it up when I had it basically working). I saw your PR for ed25519, I'm going to add a comment there too |
20ea8fe
to
b53b417
Compare
Also known as: - ecdsa-sha2-nistp256 - ecdsa-sha2-nistp384 - ecdsa-sha2-nistp521 Works for .NET 3.5 and 4.0 but needs some more testing and tests. Basically it translate between SSH-Data and Microsoft Crypto API. Tested with ECDSA-{256,384,521} Hostkeys and ECDSA-{256,384,521}-Pub/Private-Keys against OpenSSH_7.2p2 Ubuntu-4ubuntu2.4, OpenSSL 1.0.2g 1 Mar 2016. Keys generated with: - ssh-keygen -t ecdsa - ssh-keygen -t ecdsa -b 384 - ssh-keygen -t ecdsa -b 521
Closing in favor of: #496 |
Also known as:
Works but needs some more testing and tests, but already opening an PR so it can be discussed.
Basically it translate between SSH-Data and Microsoft Crypto API.
Tested with ECDSA-{256,384,521} Hostkeys and ECDSA-{256,384,521}-Pub/Private-Keys
against OpenSSH_7.2p2 Ubuntu-4ubuntu2.4, OpenSSL 1.0.2g 1 Mar 2016.
Keys generated with: