Elliptic Curves #496

darinkes · 2018-12-02T19:40:28Z

Latest approach to implement Elliptic Curves Support in SSH.NET.

ED25519 and Curve25519 for KEX, Hostkey and Private Keys
- Import of https://github.com/CodesInChaos/Chaos.NaCl
- Timing Safe implementation
- Public Domain
ECDH
- Minimal Import (just the needed parts) of http://www.bouncycastle.org/csharp/
- MIT like License
- Microsoft's ECDiffieHellmanCng doesn't work... :/
- Timing Safe is not important for KEX, since keys don't live long. Couldn't find any verification that it resists timing attacks
ECDSA for Hostkey and Private Keys
- System.Security.Cryptography.ECDsaCng
- Timing Safe (hopefully! ;))

Performance-Comparison Key-Exchange:

Code

var sw = Stopwatch.StartNew();
using (var client = new SshClient(coninfo))
{
     client.Connect();
     Console.WriteLine(client.RunCommand("hostname").Result);
     client.Disconnect();
}
sw.Stop();
Console.WriteLine("Time taken: {0}ms", sw.Elapsed.TotalMilliseconds);

diffie-hellman-group-exchange-sha256
Time taken: 2365,9079ms
curve25519-sha256
Time taken: 1169,3554ms
ecdh-sha2-nistp256
Time taken: 1053,3225ms

drieseng · 2018-12-02T20:26:23Z

@darinkes Is this the minimal set of sources we need to "import"?

Kim-SSi · 2018-12-03T03:44:04Z

It is all in the src/Renci.SshNet/Security/BouncyCastle folder. See:
https://github.com/darinkes/SSH.NET-1/tree/elliptic/src/Renci.SshNet/Security/BouncyCastle/src

If this is the approach taken, please change the namespace to avoid collisions with the BouncyCastle assemblies or make it all internal - provided that is possible.
namespace Org.BouncyCastle...
to or similar e.g:
namespace Renci.SshNet.Org.BouncyCastle...

darinkes · 2018-12-03T06:27:12Z

@drieseng
I think there can be done more. E.g. the in the ASN.1 folder of BouncyCastle. And remove stuff marked as obsolete.

Edit:
And of course reenable build warnings/errors again.

darinkes · 2018-12-03T07:58:03Z

@drieseng
I think there can be done more. E.g. the in the ASN.1 folder of BouncyCastle. And remove stuff marked as obsolete.

Okay, was wrong here twice :)
ASN.1 is a chain of dependencies and BouncyCastle relies internally on stuff they marked as obsolete.

Edit:
And of course reenable build warnings/errors again.

Done! All now in an internal namespace, nothing gets exposed.

Whats the best/easiest way to enable the Build for all the other projects?

darinkes · 2018-12-03T11:20:41Z

Ok, the last Build Fails are not my fault :)

This Test seems to flipper:
Renci.SshNet.Tests.Classes.SessionTest_Connected_ServerSendsBadPacket.ReceiveOnServerSocketShouldReturnZero()
First all passed, then failed on .NET 3.5 and now .NET.
And all I changed was the Commit Messages to trigger an rebuild.

darinkes · 2018-12-04T20:52:48Z

Spend some time on cleaning up all the commits and (hopefully) split them in reasonable/reviewable parts.

darinkes · 2018-12-05T11:04:11Z

@drieseng
I think there can be done more. E.g. the in the ASN.1 folder of BouncyCastle. And remove stuff marked as obsolete.

Okay, was wrong here twice :)
ASN.1 is a chain of dependencies and BouncyCastle relies internally on stuff they marked as obsolete.

Got rid most of the stuff in the asn.1 folder with some minor adjustments in the sources. Over 10k Lines less than before.

drieseng · 2018-12-05T14:00:15Z

Please also add a THIRD-PARTY-NOTICES.TXT to the repo, and include the BouncyCastle and Chaos.NaCl licenses. You can find inspiration here.

src/Renci.SshNet.NETCore/Renci.SshNet.NETCore.csproj

src/Renci.SshNet/Common/DerData.cs

src/Renci.SshNet/PrivateKeyFile.cs

src/Renci.SshNet/Security/Cryptography/Bcrypt.cs

src/Renci.SshNet/Security/BouncyCastle/src/asn1/sec/SECNamedCurves.cs

src/Renci.SshNet/Common/Extensions.cs

drieseng · 2018-12-05T14:16:12Z

src/Renci.SshNet/Security/KeyHostAlgorithm.cs

@@ -92,7 +92,7 @@ public BigInteger[] Keys
                    for (var i = 0; i < _keys.Count; i++)
                    {
                        var key = _keys[i];
-                        keys[i] = key.ToBigInteger();
+                        keys[i] = BigInteger.SshFormatBignum2(key);


Care to explain why this is necessary? Would this break other algorithms?

If a Key comes with a leading "FF", the current ToBigInteger() would drop this "FF" and we have invalid data. That gets prevented by appending an "00" before the "FF".

Made a lot of testruns with DSA and RSA and had no Problems.

Can you add a test that covers this?
Haven't had time to check if this is trivial.

Basically it's this: https://github.com/openssh/openssh-portable/blob/master/sshbuf-getput-crypto.c#L147

bhalbright · 2018-12-05T15:00:11Z

Please also add a THIRD-PARTY-NOTICES.TXT to the repo, and include the BouncyCastle and Chaos.NaCl licenses. You can find inspiration here.

For what its worth, the BCrypt that I added came from here: https://bitbucket.org/vadim/bcrypt.net/src/9016bf211b5bc7406e01f2f99fe5b868b1e35238/BCrypt.Net/BCrypt.cs?at=default&fileviewer=file-view-default, with a few additions for the kdf stuff. Not sure if that needs to go in the 3rd party file mentioned, but wanted to point it out

darinkes · 2018-12-09T12:09:21Z

Merged the Linux Support to "Add Support for ECDSA Host- and Private-Keys", since this makes automatic real life testing much much easier.

gargml · 2019-02-06T06:46:41Z

Hi Guys,
I must share that the requirement of supporting Elliptic Curves in SSH.NET, is raising from day to day,
Hence, will it be possible to share if you have any estimations when will such support will be added to the SSH.NET library ?
Is there some beta version i can test ?
Please share

MikeBairdRocks · 2019-06-26T18:50:51Z

@drieseng How can we get this out the door? Any help needed with the review? Seems there is a need for this by a few people. I know 30k line diff is a little overwhelming. 🤔

darinkes · 2019-06-27T05:56:30Z

@MikeBairdRocks tests and comments are always welcome and I'm sure they help to get this in.

kv9y · 2019-07-12T15:37:22Z

Is there any way I could get a version of SSH.NET with KEX ecdh-sha2-nistp256 from this PR, enabled? I would be more than happy to test, comment, what-have-you. Just point me in the correct direction.

Psilax · 2019-08-20T08:50:57Z

Another month further, any more feedback on the planning to release this feature @drieseng and what is required for this?

kv9y · 2019-09-03T15:15:33Z

Is there any update on this PR?

BorisAmelyan

can we release OPENSSH?

darinkes · 2019-12-04T06:25:17Z

🎉🎁🎂

lifeincha0s · 2020-01-10T23:46:44Z

I have been working through the code to update crypto to be FIPS compliant. I added diffie-hellman-group14-sha256, diffie-hellman-group16-sha512, and diffie-hellman-group18-sha512. I wrote ecdh-sha2-nistp256 as research for my grad crypto class, so I implemented it without using any Microsoft or 3rd party libraries. I chose that option because using .NET crypto required adding too much overly complicated code for it to be usable for public and shared key creation, as well as generating signatures for kex. 3rd party libraries have so much overhead that I would rather implement my own functionality. I am also removing antiquated code to stay up with RFC standards (i.e. anything from SSHv1)

darkoperator · 2020-01-10T23:57:21Z

Beginning to think if someone in the community with Crypto knowledge would fork it. It has been way to long without an update.

…

On Jan 10, 2020, at 7:46 PM, lifeincha0s ***@***.***> wrote: I have been working through the code to update crypto to be FIPS compliant. I added diffie-hellman-group14-sha256, diffie-hellman-group16-sha512, and diffie-hellman-group18-sha512. I wrote ecdh-sha2-nistp256 as research for my grad crypto class, so I implemented it without using any Microsoft or 3rd party libraries. I chose that option because using .NET crypto required quite a bit of overly complicated code for it to be usable for key generation, shared key creation — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#496?email_source=notifications&email_token=AAD7IHVFZUATYNNSKBQALS3Q5ECGNA5CNFSM4GHWHX32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIVRMLA#issuecomment-573249068>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD7IHT2PSUKPHIGER3ZM7DQ5ECGNANCNFSM4GHWHX3Q>.

drieseng · 2020-01-11T09:58:51Z

I'm reviewing this PR right now.
I hope to have it merged this weekend.

drieseng · 2020-01-11T10:38:43Z

@darinkes Can you, for all of the third party sources you added, indicate where you obtained the sources from (source distribution, git(hub), ...), and what exact version of these sources? Thanks for this great contribution!

…nd private key formats.

BorisAmelyan · 2020-01-12T18:13:00Z

when will the new version be available for upgrade on NugetPackage manager?

drieseng · 2020-01-12T18:59:01Z

I've lost my VMs for building SSH.NET on all supported target frameworks.
I hope to be able to complete this in the next two weeks, but no promises.

BorisAmelyan · 2020-01-12T19:14:09Z

Thank you!

darinkes · 2020-01-13T08:36:14Z

@darinkes Can you, for all of the third party sources you added, indicate where you obtained the sources from (source distribution, git(hub), ...), and what exact version of these sources? Thanks for this great contribution!

Chaos.NaCl: CodesInChaos/Chaos.NaCl@2c86134
BouncyCastle: Based on Version 1.8.3 from http://www.bouncycastle.org/csharp/

This was referenced Dec 2, 2018

WIP: Support for Ed25519 Host- and Private-Keys #492

Closed

WIP: Add Support for ECDSA Host- and Private-Keys #489

Closed

darinkes force-pushed the elliptic branch 2 times, most recently from 95662d7 to 91ccbbb Compare December 2, 2018 19:50

darinkes force-pushed the elliptic branch from 91ccbbb to ad7c120 Compare December 3, 2018 07:56

darinkes force-pushed the elliptic branch 6 times, most recently from fcd5540 to 9b76b84 Compare December 3, 2018 11:12

darinkes force-pushed the elliptic branch 4 times, most recently from cb2a922 to 6fecae9 Compare December 4, 2018 20:51

darinkes force-pushed the elliptic branch 2 times, most recently from 3d969da to 7a13b54 Compare December 5, 2018 11:00

darinkes mentioned this pull request Dec 5, 2018

System.NotSupportedException: Key 'OPENSSH' is not supported. #485

Closed

drieseng requested changes Dec 5, 2018

View reviewed changes

darinkes force-pushed the elliptic branch 2 times, most recently from 9d07604 to b367b1b Compare December 6, 2018 07:50

darinkes force-pushed the elliptic branch from 8bccf40 to 54f42e4 Compare December 9, 2018 12:03

darinkes and others added 2 commits December 9, 2018 16:41

Support for Ed25519 Host- and Private-Keys

c9f9e3c

Enable Build of Elliptic-Curves for other Projects

7d73651

darinkes force-pushed the elliptic branch from 54f42e4 to 7d73651 Compare December 9, 2018 15:42

darinkes mentioned this pull request Apr 20, 2019

ed25519 private keys are not supported. #20

Closed

darinkes mentioned this pull request Jun 4, 2019

Supported Key Exchange #550

Closed

darinkes mentioned this pull request Nov 6, 2019

Key 'OPENSSH' is not supported. #570

Closed

BorisAmelyan approved these changes Nov 6, 2019

View reviewed changes

Update readme for the new key exchange methods, host key algorithms a…

982ef10

…nd private key formats.

drieseng approved these changes Jan 11, 2020

View reviewed changes

drieseng merged commit 546e2b9 into sshnet:develop Jan 11, 2020

fgodskesen mentioned this pull request Aug 19, 2020

no support for elliptic curve (ssh-ed25519) "Failed to negotiate key exchange algorithm" darkoperator/Posh-SSH#343

Closed

tobiasschuerg mentioned this pull request Nov 25, 2020

Add SSH support for elliptic-curve cryptography aka ECDSA duplicati/duplicati#4378

Closed

1 task

WojciechNagorski mentioned this pull request Dec 10, 2023

Third party libraries #1271

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Elliptic Curves #496

Elliptic Curves #496

darinkes commented Dec 2, 2018

drieseng commented Dec 2, 2018

Kim-SSi commented Dec 3, 2018 •

edited

Loading

darinkes commented Dec 3, 2018 •

edited

Loading

darinkes commented Dec 3, 2018 •

edited

Loading

darinkes commented Dec 3, 2018

darinkes commented Dec 4, 2018

darinkes commented Dec 5, 2018

drieseng commented Dec 5, 2018

drieseng Dec 5, 2018

darinkes Dec 5, 2018

drieseng Dec 5, 2018

darinkes Dec 5, 2018

bhalbright commented Dec 5, 2018

darinkes commented Dec 9, 2018

gargml commented Feb 6, 2019

MikeBairdRocks commented Jun 26, 2019

darinkes commented Jun 27, 2019

kv9y commented Jul 12, 2019 •

edited

Loading

Psilax commented Aug 20, 2019

kv9y commented Sep 3, 2019

BorisAmelyan left a comment

darinkes commented Dec 4, 2019

lifeincha0s commented Jan 10, 2020 •

edited

Loading

darkoperator commented Jan 10, 2020 via email

drieseng commented Jan 11, 2020

drieseng commented Jan 11, 2020 •

edited

Loading

BorisAmelyan commented Jan 12, 2020

drieseng commented Jan 12, 2020

BorisAmelyan commented Jan 12, 2020

darinkes commented Jan 13, 2020

Elliptic Curves #496

Elliptic Curves #496

Conversation

darinkes commented Dec 2, 2018

drieseng commented Dec 2, 2018

Kim-SSi commented Dec 3, 2018 • edited Loading

darinkes commented Dec 3, 2018 • edited Loading

darinkes commented Dec 3, 2018 • edited Loading

darinkes commented Dec 3, 2018

darinkes commented Dec 4, 2018

darinkes commented Dec 5, 2018

drieseng commented Dec 5, 2018

drieseng Dec 5, 2018

Choose a reason for hiding this comment

darinkes Dec 5, 2018

Choose a reason for hiding this comment

drieseng Dec 5, 2018

Choose a reason for hiding this comment

darinkes Dec 5, 2018

Choose a reason for hiding this comment

bhalbright commented Dec 5, 2018

darinkes commented Dec 9, 2018

gargml commented Feb 6, 2019

MikeBairdRocks commented Jun 26, 2019

darinkes commented Jun 27, 2019

kv9y commented Jul 12, 2019 • edited Loading

Psilax commented Aug 20, 2019

kv9y commented Sep 3, 2019

BorisAmelyan left a comment

Choose a reason for hiding this comment

darinkes commented Dec 4, 2019

lifeincha0s commented Jan 10, 2020 • edited Loading

darkoperator commented Jan 10, 2020 via email

drieseng commented Jan 11, 2020

drieseng commented Jan 11, 2020 • edited Loading

BorisAmelyan commented Jan 12, 2020

drieseng commented Jan 12, 2020

BorisAmelyan commented Jan 12, 2020

darinkes commented Jan 13, 2020

Kim-SSi commented Dec 3, 2018 •

edited

Loading

darinkes commented Dec 3, 2018 •

edited

Loading

darinkes commented Dec 3, 2018 •

edited

Loading

kv9y commented Jul 12, 2019 •

edited

Loading

lifeincha0s commented Jan 10, 2020 •

edited

Loading

drieseng commented Jan 11, 2020 •

edited

Loading