Preserve exception stack trace in Session.WaitOnHandle() #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviburg
suggested changes
Nov 23, 2020
Throwing _exception loses the original stack trace, making it difficult to debug problems. Original stack trace is now saved in the exception data for .NET 3.5 and 4.0 clients, or correctly rethrown with the full stack for .NET Standard 1.3 and 2.0 clients using ExceptionDispatchInfo.
bretthysuik
force-pushed
the
keep-strack-trace
branch
from
7cd32c3
to
afcb8b7
Compare
daviburg
approved these changes
Nov 26, 2020
|
PR needs refreshing. If you feel this change is needed, feel free to open the current PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwing
_exceptionloses the original stack trace, making it difficult to debug problems.Original stack trace is now saved in the exception data for .NET 3.5 and 4.0 clients, or
correctly rethrown with the full stack for .NET Standard 1.3 and 2.0 clients.