Add unit tests for task-based asynchronous API #906

IgorMilavec · 2021-12-15T22:31:30Z

I have created some unit tests for async API as a basis for discussion.
@drieseng can you please have a look if I'm kicking in the right direction?

Basically I plan to duplicate these tests:

SftpFileStreamTest_Ctor_* -> SftpFileStreamTest_OpenAsync_*
SftpFileStreamTest_Read_* -> SftpFileStreamTest_ReadAsync_*
SftpClientTest.* -> SftpClientTest.*Async
Have I left out any major surface area?

I have removed unsupported targets from the Tests project. I have tried to list all the relevant (and supported) targets for each VS version. I've left net35 in as it is the last one running on 2.0 runtime.

…targets

IgorMilavec · 2021-12-17T08:59:28Z

@drieseng, looks like I have opened a can of worms by running the tests on net5.0. :) Some tests were using runtime dependent code and had timing issues. I hope I have fixed those tests.
However, the tests are still very fragile. They pass when run locally, but when run by AppVeyor, they fail in sporadic and mysterious ways.

What I propose to do:

Remove all the assertions on Exception.Message, as these are runtime and (English) culture dependent.
ExceptionShouldNotHaveFired provides no feedback as to what exception occurred. We should replace all the occurrences with:

[TestMethod]
public void ExceptionShouldNotHaveFired()
{
    if (_exceptionRegister.Count > 0)
    {
        throw new Exception("ForwardedPort rased an exception: " + _exceptionRegister[0].Exception.Message, _exceptionRegister[0].Exception);
    }
}

I have already replaced ExceptionShouldNotHaveFired in ForwardedPortDynamicTest_Dispose_PortStarted_ChannelNotBound and now it fails with:

  Failed ExceptionShouldNotHaveFired [97 ms]
  Error Message:
   Test method Renci.SshNet.Tests.Classes.ForwardedPortDynamicTest_Dispose_PortStarted_ChannelNotBound.ExceptionShouldNotHaveFired threw exception: 
System.Exception: ForwardedPortDynamic rased an exception: An established connection was aborted by the software in your host machine. ---> System.Net.Sockets.SocketException: An established connection was aborted by the software in your host machine.
  Stack Trace:
      at System.Net.Sockets.Socket.Receive(Byte[] buffer, Int32 offset, Int32 size, SocketFlags socketFlags)
   at Renci.SshNet.Abstractions.SocketAbstraction.Read(Socket socket, Byte[] buffer, Int32 offset, Int32 size, TimeSpan readTimeout) in C:\projects\ssh-net\src\Renci.SshNet\Abstractions\SocketAbstraction.cs:line 371
   at Renci.SshNet.Abstractions.SocketAbstraction.ReadByte(Socket socket, TimeSpan timeout) in C:\projects\ssh-net\src\Renci.SshNet\Abstractions\SocketAbstraction.cs:line 289
   at Renci.SshNet.ForwardedPortDynamic.HandleSocks(IChannelDirectTcpip channel, Socket clientSocket, TimeSpan timeout) in C:\projects\ssh-net\src\Renci.SshNet\ForwardedPortDynamic.NET.cs:line 189
--- End of inner exception stack trace ---
    at Renci.SshNet.Tests.Classes.ForwardedPortDynamicTest_Dispose_PortStarted_ChannelNotBound.ExceptionShouldNotHaveFired() in C:\projects\ssh-net\src\Renci.SshNet.Tests\Classes\ForwardedPortDynamicTest_Dispose_PortStarted_ChannelNotBound.cs:line 135

"An established connection was aborted by the software in your host machine" seems to be the prevailing cause for failures on AppVeyor. I don't really know how to approach this. Could we at least mark the tests as inconclusive instead of failing them in case of this exception?

The test SendMessageOnSessionShouldBeInvokedThreeTimes consistently fails when run on net5.0:

  Failed SendMessageOnSessionShouldBeInvokedThreeTimes [376 ms]
  Error Message:
   Test method Renci.SshNet.Tests.Classes.BaseClientTest_Connected_KeepAliveInterval_NotNegativeOne.SendMessageOnSessionShouldBeInvokedThreeTimes threw exception: 
Moq.MockException: 
Expected invocation on the mock exactly 3 times, but was 4 times: p => p.TrySendMessage(It.IsAny<IgnoreMessage>())
Performed invocations:
   Mock<ISession:12> (p):
      ISession.add_HostKeyReceived(EventHandler<HostKeyEventArgs>)
      ISession.add_ErrorOccured(EventHandler<ExceptionEventArgs>)
      ISession.Connect()
      ISession.IsConnected
      ISession.TrySendMessage(SSH_MSG_IGNORE)
      ISession.TrySendMessage(SSH_MSG_IGNORE)
      ISession.TrySendMessage(SSH_MSG_IGNORE)
      ISession.TrySendMessage(SSH_MSG_IGNORE)
  Stack Trace:
      at Moq.Mock.Verify(Mock mock, LambdaExpression expression, Times times, String failMessage) in C:\projects\moq4\src\Moq\Mock.cs:line 337
   at Moq.Mock`1.Verify[TResult](Expression`1 expression, Times times) in C:\projects\moq4\src\Moq\Mock`1.cs:line 835
   at Renci.SshNet.Tests.Classes.BaseClientTest_Connected_KeepAliveInterval_NotNegativeOne.SendMessageOnSessionShouldBeInvokedThreeTimes() in C:\projects\ssh-net\src\Renci.SshNet.Tests\Classes\BaseClientTest_Connected_KeepAliveInterval_NotNegativeOne.cs:line 97

As you have more insight into the codebase I kindly ask you if you can have a look at it

zybexXL · 2021-12-17T11:01:37Z

I'm also seeing AppVeyor failing a lot due to port exhaustion - I mentioned this before on #877 (comment)

…sConnectedAndChannelIsOpen

zybexXL · 2021-12-17T16:34:32Z

Still failing on AppVeyor, seems to be a different issue:

Test method Renci.SshNet.Tests.Classes.BaseClientTest_Connected_KeepAliveInterval_NotNegativeOne.SendMessageOnSessionShouldBeInvokedThreeTimes threw exception: 
Moq.MockException: 
Expected invocation on the mock exactly 3 times, but was 4 times: p => p.TrySendMessage(It.IsAny<IgnoreMessage>())

IgorMilavec · 2021-12-17T17:02:32Z

Lots o' issues. :) That is the last non-sporadic one, hopefully it is fixed now...

…different targets

IgorMilavec · 2022-02-10T22:01:11Z

@drieseng, can you please have a look a this? In addition to adding coverage it also fixes a lot of transient errors, which blocks a lot of other PRs.

drieseng

Overall this PR looks great.
I indicated a few changes that I'd like to move out of this PR.
In general, please try to have smaller PRs.
PS. I happen to get carried away myself, so don't hesitate to remind me of this as well (and reject my PRs for the same reason).

drieseng · 2022-02-11T21:54:35Z

src/Renci.SshNet.Tests/Classes/BaseClientTest_Connected_KeepAliveInterval_NotNegativeOne.cs

@@ -94,7 +97,7 @@ public void IsConnectedOnSessionShouldBeInvokedOnce()
        [TestMethod]
        public void SendMessageOnSessionShouldBeInvokedThreeTimes()
        {
-            _sessionMock.Verify(p => p.TrySendMessage(It.IsAny<IgnoreMessage>()), Times.Exactly(3));
+            Assert.AreEqual(3, _actualKeepAliveCount);


Why do you prefer this over verifying the mock?

It was the only way I found to stop this test failing sporadically for me. Let me remove non-Async changes from the PR and then we'll disuss, OK?

OK. I flagged some other changes that you can keep in this PR.

and .... THANKS!

drieseng · 2022-02-11T21:55:59Z

appveyor.yml

@@ -1,5 +1,8 @@
 os: Visual Studio 2019

+init:
+ - netsh int ipv4 set dynamicport tcp start=1025 num=64510


Did this resolve any issues?

It was more of a "we open and close a lot of ports in tests and the tests are sporadically failing with connection failures, so more client-side ports can't hurt" line of reasoning.

drieseng · 2022-02-11T21:57:16Z

appveyor.yml


-    vstest.console /logger:Appveyor src\Renci.SshNet.Tests\bin\Debug\net35\Renci.SshNet.Tests.dll /TestCaseFilter:"TestCategory!=integration&TestCategory!=LongRunning"


I'd first like to discuss dropping .NET 3.5 support.
Perhaps we'll have a final release supporting the legacy frameworks.
As I said, let's discuss this first.

drieseng · 2022-02-11T21:58:09Z

...sts/Classes/Channels/ChannelForwardedTcpipTest_Dispose_SessionIsConnectedAndChannelIsOpen.cs

@@ -51,17 +51,13 @@ public void CleanUp()
                _remoteListener = null;
            }

-            if (_channelThread != null)
-            {
-                if (_channelThread.IsAlive)


I suppose you did this because Thread.Abort is no longer supported on .NET (Core).

drieseng · 2022-02-11T21:59:06Z

...sts/Classes/Channels/ChannelForwardedTcpipTest_Dispose_SessionIsConnectedAndChannelIsOpen.cs

@@ -138,10 +134,12 @@ private void Arrange()
                _remoteWindowSize,
                _remotePacketSize);

+            ManualResetEvent isReady = new ManualResetEvent(false);


I suppose this resolves an issue, but I always prefer to see the issue before a fix is applied for it.

drieseng · 2022-02-11T22:01:10Z

src/Renci.SshNet.Tests/Classes/Common/PipeStream_Close_BlockingWrite.cs


        protected override void Arrange()
        {
            _pipeStream = new PipeStream {MaxBufferLength = 3};

-            _writehread = new Thread(() =>
+            ManualResetEvent isArranged = new ManualResetEvent(false);


I suppose this resolves an issue, but I always prefer to see the issue before a fix is applied for it.
Let's separate this and similar changes out.

drieseng · 2022-02-11T22:01:31Z

src/Renci.SshNet.Tests/Classes/Connection/DirectConnectorTest_Connect_HostNameInvalid.cs

@@ -36,7 +36,10 @@ public void ConnectShouldHaveThrownSocketException()
        {
            Assert.IsNotNull(_actualException);
            Assert.IsNull(_actualException.InnerException);
-            Assert.AreEqual(SocketError.HostNotFound, _actualException.SocketErrorCode);
+            if (_actualException.SocketErrorCode != SocketError.TryAgain)


I suppose this resolves an issue, but I always prefer to see the issue before a fix is applied for it.

drieseng · 2022-02-11T22:01:41Z

src/Renci.SshNet.Tests/Classes/Connection/HttpConnectorTest_Connect_ProxyHostInvalid.cs

@@ -43,7 +43,10 @@ public void ConnectShouldHaveThrownSocketException()
        {
            Assert.IsNotNull(_actualException);
            Assert.IsNull(_actualException.InnerException);
-            Assert.AreEqual(SocketError.HostNotFound, _actualException.SocketErrorCode);
+            if (_actualException.SocketErrorCode != SocketError.TryAgain)


I suppose this resolves an issue, but I always prefer to see the issue before a fix is applied for it.

drieseng · 2022-02-11T22:02:35Z

src/Renci.SshNet/ForwardedPortDynamic.NET.cs

@@ -202,6 +202,12 @@ private bool HandleSocks(IChannelDirectTcpip channel, Socket clientSocket, TimeS
            }
            catch (SocketException ex)
            {
+                if (ex.SocketErrorCode == SocketError.ConnectionAborted)


I suppose this resolves an issue, but I always prefer to see the issue before a fix is applied for it.

drieseng · 2022-02-11T22:03:35Z

src/Renci.SshNet.Tests/Common/AsyncSocketListener.cs

@@ -193,12 +192,37 @@ private void ReadCallback(IAsyncResult ar)
            {
                // Read data from the client socket.
                bytesRead = handler.EndReceive(ar);
+
+                if (bytesRead > 0)


I suppose this resolves an issue, but I always prefer to see the issue before a fix is applied for it.

IgorMilavec · 2022-02-14T20:32:56Z

@drieseng I think I have removed all changes unrelated to the issue at hand, can you please review again?

drieseng · 2022-02-12T10:56:44Z

...Net.Tests/Classes/ScpClientTest_Download_PathAndDirectoryInfo_SendExecRequestReturnsFalse.cs

+#if NET35
            _pipeStreamMock.As<IDisposable>().Verify(p => p.Dispose(), Times.Once);
+#else
+            _pipeStreamMock.Verify(p => p.Close(), Times.Once);
+#endif


@IgorMilavec No need to move these changes (here and elsewhere) out of this PR.

drieseng · 2022-02-12T10:57:04Z

src/Renci.SshNet.Tests/Classes/NetConfClientTest.cs

+#if NETFRAMEWORK
                Assert.AreEqual("The timeout must represent a value between -1 and Int32.MaxValue, inclusive." + Environment.NewLine + "Parameter name: " + ex.ParamName, ex.Message);
+#else
+                Assert.AreEqual("The timeout must represent a value between -1 and Int32.MaxValue, inclusive. (Parameter '" + ex.ParamName + "')", ex.Message);
+#endif


@IgorMilavec No need to move these changes (here and elsewhere) out of this PR.

drieseng · 2022-02-12T10:58:41Z

src/Renci.SshNet.Tests/Classes/ForwardedPortDynamicTest_Stop_PortStarted_ChannelNotBound.cs

+            if (_exceptionRegister.Count > 0)
+            {
+                throw new Exception("ForwardedPortDynamic rased an exception: " + _exceptionRegister[0].Exception.Message, _exceptionRegister[0].Exception);
+            }


@IgorMilavec No need to move these changes (here and elsewhere) out of this PR.

drieseng · 2022-02-12T10:59:34Z

src/Renci.SshNet.Tests/Classes/BaseClientTest_Connected_KeepAliveInterval_NotNegativeOne.cs

@@ -94,7 +97,7 @@ public void IsConnectedOnSessionShouldBeInvokedOnce()
        [TestMethod]
        public void SendMessageOnSessionShouldBeInvokedThreeTimes()
        {
-            _sessionMock.Verify(p => p.TrySendMessage(It.IsAny<IgnoreMessage>()), Times.Exactly(3));
+            Assert.AreEqual(3, _actualKeepAliveCount);


OK. I flagged some other changes that you can keep in this PR.

drieseng · 2022-02-12T10:59:46Z

src/Renci.SshNet.Tests/Classes/BaseClientTest_Connected_KeepAliveInterval_NotNegativeOne.cs

@@ -94,7 +97,7 @@ public void IsConnectedOnSessionShouldBeInvokedOnce()
        [TestMethod]
        public void SendMessageOnSessionShouldBeInvokedThreeTimes()
        {
-            _sessionMock.Verify(p => p.TrySendMessage(It.IsAny<IgnoreMessage>()), Times.Exactly(3));
+            Assert.AreEqual(3, _actualKeepAliveCount);


and .... THANKS!

IgorMilavec · 2022-02-15T22:07:40Z

@drieseng thanks to you for putting in all the effort!

drieseng · 2022-02-16T19:31:35Z

@IgorMilavec You're getting it wrong: you did the effort here! Thanks!

* Fix runtime and culture dependant tests. * Set C# 7.3 in Tests.csproj to limit intellisense's suggestions under different targets * Add SftpClientTest.*Async * Add SftpFileStreamTest_OpenAsync_* * Add SftpFileStreamTest_WriteAsync_* * Add SftpFileStreamTest_ReadAsync_* * Align AppVeyor script with Test project target frameworks

@clivetong

* Assets/logos (#782) * Added logo assets * Added PNG 1260x640 with white border Co-authored-by: 103filgualan <f.gualandi@crif.com> * OPENSSH KeyReader for more keys (#614) * OPENSSH KeyReader for more keys Add support to parse OpenSSH Keys with ECDSA 256/384/521 and RSA. https://github.com/openssh/openssh-portable/blob/master/PROTOCOL.key Change-Id: Iaa9cce0f2522e5fee377a82cb252f81f0b7cc563 * Fix ED25519Key KeyLength * Fix ED25519 PubKey-auth LeadingZeros of BigInteger-Conversion have to be removed before sending the Key. * Add interface to SftpFile #120 (#812) * Create ISftpFile interface. SftpFile sealed. Return ISftpFile from SftpClient instead of SftpFile. Make ISftpClient interface disposable. Co-authored-by: Wojciech Swieboda <wswieboda@chathamfinancial.com> * Start MessageListener with ThreadAbstraction.ExecuteThreadLongRunning (#902) * Fix Thread pool exhaustion due to MessageListener running on ThreadPool * Mark long running thread as background * Add async support to SftpClient and SftpFileStream (#819) * Add FEATURE_TAP and net472 target * Add TAP async support to SftpClient and SftpFileStream * Add async support to DnsAbstraction and SocketAbstraction * Add async support to *Connector and refactor the hierarchy * Add ConnectAsync to BaseClient * Add CODEOWNERS file. * Fix virus false-positive by Defender on Renci.SSHNet.Tests.dll (#867) Co-authored-by: Pedro Fonseca <pfonseca@qti.qualcomm.com> * Add unit tests for task-based asynchronous API (#906) * Fix runtime and culture dependant tests. * Set C# 7.3 in Tests.csproj to limit intellisense's suggestions under different targets * Add SftpClientTest.*Async * Add SftpFileStreamTest_OpenAsync_* * Add SftpFileStreamTest_WriteAsync_* * Add SftpFileStreamTest_ReadAsync_* * Align AppVeyor script with Test project target frameworks * correct 'Documenation' to 'Documentation' (#838) in the documentation's window title * Agent auth and Keygen (#794) * Allow to set PrivateKeyFile Key directly So you can add your own Key-Classes to SSH.NET * Add ED25519 ctor for just pub key part. * Make ECDSA Key Bits accessible You cant export imported CngKeys. To be able to export them to agent or Key-Files make the private bits also accessible. * Better NETFRAMEWORK vs NETSTANDARD handling * Add Comment Property to Key * Add IPrivateKeySource So Extension can add own PrivateKeyFiles, e.g. PuttyKeyFile. * Use cryptographically secure random number generator. Fixes CVE-2022-29245. * Remove unused import. * Add IBaseClient for BaseClient and ISftpClient to inherit from (#975) Add IBaseClient for BaseClient and ISftpClient to inherit from * fix typo (#999) * Fix Seek Operations in SftpFileStream (#910) * Fix offset operations in SftpFileStream.Seek * Fix seek exception message and add default case for invalid seek origin * Use named params when throwing ArgumentException * Add tests for seeking from end of file * Add back copyright to license. (#1060) Fixes #1059. * Removing old target frameworks (#1109) Remove support for legacy / deprecated target frameworks while adding support for .NET 6.0 (and higher). The supported target frameworks are now: * .NETFramework 4.6.2 (and higher) * .NET Standard 2.0 * .NET 6.0 (and higher) * Remove old features [Part 1] (#1117) Remove obsolete feature switches (now that we've remove support for legacy target frameworks) and remove corresponding conditional code. * Remove FEATURE_DIRECTORYINFO_ENUMERATEFILES (#1119) * Remove FEATURE_DIRECTORYINFO_ENUMERATEFILES * Add exception documentation * Fix some (lots of) issues reported by analyzers. (#1125) Fix some (lots of) issues reported by analyzers. * Round 2 of analyzer fixes and general cleanup. (#1132) * Analyzer fixes round 3. (#1135) * Replace Array<T>.Empty with Array.Empty<T>() (#1137) * Replace IsNullOrWhiteSpace extension (#1142) * Use License Expression for NuGet Package licenseUrl is deprecated, see NuGet/Announcements#32 * Integration tests * Remove todos * Update CODEOWNERS * Use correct SSH.NET * ListDirectoryAsync return IAsyncEnumerable (#1126) * ListDirectoryAsync return IAsyncEnumerable * Fix documentation * Update README.md * Fix * Add Sftp ListDirectoryAsync test * Revert * Integration tests for ListDirectoryAsync with IAsyncEnumerable * Fix the assembly resolution build warning (#1165) * Delete performance/longrunning tests (#1143) Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> * Move Integration tests (#1173) * Renci.SshNet.IntegrationTests * Renci.SshNet.TestTools.OpenSSH * Move integration tests to main repo * Move old tests to new integration tests * Move old integration tests to new integration tests * Move more tests * Move authentication tests * Move SshClientTests * Fix some tests * Remove duplicated test * Poc of ProcessDisruptor * Rename * Some fixes * Remove performance tests * Small improvements * Add a benchmarks project (#1151) * Add a benchmarks project * Small improvements --------- Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> * Use ExceptionDispatchInfo to retain call stack in Session.WaitOnHandle() (#936) * Use ExceptionDispatchInfo to retain call stack in Session.WaitOnHandle() * merge * Update src/Renci.SshNet/Session.cs Co-authored-by: Rob Hague <rob.hague00@gmail.com> --------- Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> Co-authored-by: Rob Hague <rob.hague00@gmail.com> * Support SHA256 fingerprints for host key validation (#1098) * Add tests for HostKeyEventArgs * Add SHA256 fingerprint support * Add support for RSA SHA-2 public key algorithms (#1177) * Abstract out the hash algorithm from RsaDigitalSignature * Add integration tests * Add DigitalSignature property to KeyHostAlgorithm * Add IHostAlgorithmsProvider interface * Verify the host signature * Fix HostKeyEventArgsTest after merge * Remove PubkeyAcceptedAlgorithms ssh-rsa * Add test coverage for RSA keys in PrivateKeyFile * Obsolete IPrivateKeySource --------- Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> * Improvements after #1177 (#1180) * Use ExceptionDispatchInfo in more places (#1182) Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> * Try to "fix" the flaky test (#1185) * Enable DSA tests (#1181) Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> * FingerPrints (#1186) * Use OS-agnostic socket error codes to allow tests run on different OSes (#1179) SocketErrorCode is OS agnostic, ErrorCode is OS specific. On Windows ErrorCode = (int) SocketErrorCode, but on Mac and Unix it is not. For example ExitCode for HostNotFound (11001) on Windows is 11001, on Mac & Unix is -131073. So testing for ExitCode == 11001 fails on Mac & Unix. Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> * Fix for channel session semaphore from thread blocking (#1071) * Merging fix from @clivetong into our own SSH.NET fork - The following article describes some of the issues with the double check lock that we have seen issues with: https://www.sudhanshutheone.com/posts/double-check-lock-csharp * Merging fix from @clivetong into our own SSH.NET fork - The following article describes some of the issues with the double check lock that we have seen issues with: https://www.sudhanshutheone.com/posts/double-check-lock-csharp * Update Channel to fix AppVeyor failure (field should be readonly) * Update ISftpClient for #120 (#1193) * Implement set last write and access time (#1194) * Add/migrate hmac+cipher integration tests (#1189) * Add/migrate hmac+cipher integration tests * fix integration tests --------- Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> * Update tests for SetLastAccessTime(Utc) to also verify the time component and the Kind of the DateTime value returned by GetLastAccessTime(Utc). (#1198) --------- Co-authored-by: Filippo Gualandi <filippo.gualandi@gmail.com> Co-authored-by: 103filgualan <f.gualandi@crif.com> Co-authored-by: Stefan Rinkes <darinkes@users.noreply.github.com> Co-authored-by: wxtsxt <wojciech.swieboda@gmail.com> Co-authored-by: Wojciech Swieboda <wswieboda@chathamfinancial.com> Co-authored-by: Igor Milavec <igor.milavec@gmail.com> Co-authored-by: drieseng <gert.driesen@telenet.be> Co-authored-by: Pedro Fonseca <pbfonseca@gmail.com> Co-authored-by: Pedro Fonseca <pfonseca@qti.qualcomm.com> Co-authored-by: Maximiliano Jabase <maxijabase@gmail.com> Co-authored-by: Owen Krueger <37021716+Owen-Krueger@users.noreply.github.com> Co-authored-by: Masuri <psh0258@gmail.com> Co-authored-by: LemonPi314 <49930425+LemonPi314@users.noreply.github.com> Co-authored-by: Gert Driesen <gertdriesen@msn.com> Co-authored-by: Rob Hague <rob.hague00@gmail.com> Co-authored-by: Rob Hague <rh@johnstreetcapital.com> Co-authored-by: Marius Thesing <marius.thesing@gmail.com> Co-authored-by: Dāvis Mošenkovs <davikovs@gmail.com> Co-authored-by: Dmitry Tsarevich <dimhotepus@users.noreply.github.com> Co-authored-by: Patrick Yates <114094360+patrick-yates-redgate@users.noreply.github.com>

@clivetong

* Release 2023.0.0 (#1201) * Assets/logos (#782) * Added logo assets * Added PNG 1260x640 with white border Co-authored-by: 103filgualan <f.gualandi@crif.com> * OPENSSH KeyReader for more keys (#614) * OPENSSH KeyReader for more keys Add support to parse OpenSSH Keys with ECDSA 256/384/521 and RSA. https://github.com/openssh/openssh-portable/blob/master/PROTOCOL.key Change-Id: Iaa9cce0f2522e5fee377a82cb252f81f0b7cc563 * Fix ED25519Key KeyLength * Fix ED25519 PubKey-auth LeadingZeros of BigInteger-Conversion have to be removed before sending the Key. * Add interface to SftpFile #120 (#812) * Create ISftpFile interface. SftpFile sealed. Return ISftpFile from SftpClient instead of SftpFile. Make ISftpClient interface disposable. Co-authored-by: Wojciech Swieboda <wswieboda@chathamfinancial.com> * Start MessageListener with ThreadAbstraction.ExecuteThreadLongRunning (#902) * Fix Thread pool exhaustion due to MessageListener running on ThreadPool * Mark long running thread as background * Add async support to SftpClient and SftpFileStream (#819) * Add FEATURE_TAP and net472 target * Add TAP async support to SftpClient and SftpFileStream * Add async support to DnsAbstraction and SocketAbstraction * Add async support to *Connector and refactor the hierarchy * Add ConnectAsync to BaseClient * Add CODEOWNERS file. * Fix virus false-positive by Defender on Renci.SSHNet.Tests.dll (#867) Co-authored-by: Pedro Fonseca <pfonseca@qti.qualcomm.com> * Add unit tests for task-based asynchronous API (#906) * Fix runtime and culture dependant tests. * Set C# 7.3 in Tests.csproj to limit intellisense's suggestions under different targets * Add SftpClientTest.*Async * Add SftpFileStreamTest_OpenAsync_* * Add SftpFileStreamTest_WriteAsync_* * Add SftpFileStreamTest_ReadAsync_* * Align AppVeyor script with Test project target frameworks * correct 'Documenation' to 'Documentation' (#838) in the documentation's window title * Agent auth and Keygen (#794) * Allow to set PrivateKeyFile Key directly So you can add your own Key-Classes to SSH.NET * Add ED25519 ctor for just pub key part. * Make ECDSA Key Bits accessible You cant export imported CngKeys. To be able to export them to agent or Key-Files make the private bits also accessible. * Better NETFRAMEWORK vs NETSTANDARD handling * Add Comment Property to Key * Add IPrivateKeySource So Extension can add own PrivateKeyFiles, e.g. PuttyKeyFile. * Use cryptographically secure random number generator. Fixes CVE-2022-29245. * Remove unused import. * Add IBaseClient for BaseClient and ISftpClient to inherit from (#975) Add IBaseClient for BaseClient and ISftpClient to inherit from * fix typo (#999) * Fix Seek Operations in SftpFileStream (#910) * Fix offset operations in SftpFileStream.Seek * Fix seek exception message and add default case for invalid seek origin * Use named params when throwing ArgumentException * Add tests for seeking from end of file * Add back copyright to license. (#1060) Fixes #1059. * Removing old target frameworks (#1109) Remove support for legacy / deprecated target frameworks while adding support for .NET 6.0 (and higher). The supported target frameworks are now: * .NETFramework 4.6.2 (and higher) * .NET Standard 2.0 * .NET 6.0 (and higher) * Remove old features [Part 1] (#1117) Remove obsolete feature switches (now that we've remove support for legacy target frameworks) and remove corresponding conditional code. * Remove FEATURE_DIRECTORYINFO_ENUMERATEFILES (#1119) * Remove FEATURE_DIRECTORYINFO_ENUMERATEFILES * Add exception documentation * Fix some (lots of) issues reported by analyzers. (#1125) Fix some (lots of) issues reported by analyzers. * Round 2 of analyzer fixes and general cleanup. (#1132) * Analyzer fixes round 3. (#1135) * Replace Array<T>.Empty with Array.Empty<T>() (#1137) * Replace IsNullOrWhiteSpace extension (#1142) * Use License Expression for NuGet Package licenseUrl is deprecated, see NuGet/Announcements#32 * Integration tests * Remove todos * Update CODEOWNERS * Use correct SSH.NET * ListDirectoryAsync return IAsyncEnumerable (#1126) * ListDirectoryAsync return IAsyncEnumerable * Fix documentation * Update README.md * Fix * Add Sftp ListDirectoryAsync test * Revert * Integration tests for ListDirectoryAsync with IAsyncEnumerable * Fix the assembly resolution build warning (#1165) * Delete performance/longrunning tests (#1143) Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> * Move Integration tests (#1173) * Renci.SshNet.IntegrationTests * Renci.SshNet.TestTools.OpenSSH * Move integration tests to main repo * Move old tests to new integration tests * Move old integration tests to new integration tests * Move more tests * Move authentication tests * Move SshClientTests * Fix some tests * Remove duplicated test * Poc of ProcessDisruptor * Rename * Some fixes * Remove performance tests * Small improvements * Add a benchmarks project (#1151) * Add a benchmarks project * Small improvements --------- Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> * Use ExceptionDispatchInfo to retain call stack in Session.WaitOnHandle() (#936) * Use ExceptionDispatchInfo to retain call stack in Session.WaitOnHandle() * merge * Update src/Renci.SshNet/Session.cs Co-authored-by: Rob Hague <rob.hague00@gmail.com> --------- Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> Co-authored-by: Rob Hague <rob.hague00@gmail.com> * Support SHA256 fingerprints for host key validation (#1098) * Add tests for HostKeyEventArgs * Add SHA256 fingerprint support * Add support for RSA SHA-2 public key algorithms (#1177) * Abstract out the hash algorithm from RsaDigitalSignature * Add integration tests * Add DigitalSignature property to KeyHostAlgorithm * Add IHostAlgorithmsProvider interface * Verify the host signature * Fix HostKeyEventArgsTest after merge * Remove PubkeyAcceptedAlgorithms ssh-rsa * Add test coverage for RSA keys in PrivateKeyFile * Obsolete IPrivateKeySource --------- Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> * Improvements after #1177 (#1180) * Use ExceptionDispatchInfo in more places (#1182) Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> * Try to "fix" the flaky test (#1185) * Enable DSA tests (#1181) Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> * FingerPrints (#1186) * Use OS-agnostic socket error codes to allow tests run on different OSes (#1179) SocketErrorCode is OS agnostic, ErrorCode is OS specific. On Windows ErrorCode = (int) SocketErrorCode, but on Mac and Unix it is not. For example ExitCode for HostNotFound (11001) on Windows is 11001, on Mac & Unix is -131073. So testing for ExitCode == 11001 fails on Mac & Unix. Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> * Fix for channel session semaphore from thread blocking (#1071) * Merging fix from @clivetong into our own SSH.NET fork - The following article describes some of the issues with the double check lock that we have seen issues with: https://www.sudhanshutheone.com/posts/double-check-lock-csharp * Merging fix from @clivetong into our own SSH.NET fork - The following article describes some of the issues with the double check lock that we have seen issues with: https://www.sudhanshutheone.com/posts/double-check-lock-csharp * Update Channel to fix AppVeyor failure (field should be readonly) * Update ISftpClient for #120 (#1193) * Implement set last write and access time (#1194) * Add/migrate hmac+cipher integration tests (#1189) * Add/migrate hmac+cipher integration tests * fix integration tests --------- Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com> * Update tests for SetLastAccessTime(Utc) to also verify the time component and the Kind of the DateTime value returned by GetLastAccessTime(Utc). (#1198) --------- Co-authored-by: Filippo Gualandi <filippo.gualandi@gmail.com> Co-authored-by: 103filgualan <f.gualandi@crif.com> Co-authored-by: Stefan Rinkes <darinkes@users.noreply.github.com> Co-authored-by: wxtsxt <wojciech.swieboda@gmail.com> Co-authored-by: Wojciech Swieboda <wswieboda@chathamfinancial.com> Co-authored-by: Igor Milavec <igor.milavec@gmail.com> Co-authored-by: drieseng <gert.driesen@telenet.be> Co-authored-by: Pedro Fonseca <pbfonseca@gmail.com> Co-authored-by: Pedro Fonseca <pfonseca@qti.qualcomm.com> Co-authored-by: Maximiliano Jabase <maxijabase@gmail.com> Co-authored-by: Owen Krueger <37021716+Owen-Krueger@users.noreply.github.com> Co-authored-by: Masuri <psh0258@gmail.com> Co-authored-by: LemonPi314 <49930425+LemonPi314@users.noreply.github.com> Co-authored-by: Gert Driesen <gertdriesen@msn.com> Co-authored-by: Rob Hague <rob.hague00@gmail.com> Co-authored-by: Rob Hague <rh@johnstreetcapital.com> Co-authored-by: Marius Thesing <marius.thesing@gmail.com> Co-authored-by: Dāvis Mošenkovs <davikovs@gmail.com> Co-authored-by: Dmitry Tsarevich <dimhotepus@users.noreply.github.com> Co-authored-by: Patrick Yates <114094360+patrick-yates-redgate@users.noreply.github.com> * Remove code examples --------- Co-authored-by: Filippo Gualandi <filippo.gualandi@gmail.com> Co-authored-by: 103filgualan <f.gualandi@crif.com> Co-authored-by: Stefan Rinkes <darinkes@users.noreply.github.com> Co-authored-by: wxtsxt <wojciech.swieboda@gmail.com> Co-authored-by: Wojciech Swieboda <wswieboda@chathamfinancial.com> Co-authored-by: Igor Milavec <igor.milavec@gmail.com> Co-authored-by: drieseng <gert.driesen@telenet.be> Co-authored-by: Pedro Fonseca <pbfonseca@gmail.com> Co-authored-by: Pedro Fonseca <pfonseca@qti.qualcomm.com> Co-authored-by: Maximiliano Jabase <maxijabase@gmail.com> Co-authored-by: Owen Krueger <37021716+Owen-Krueger@users.noreply.github.com> Co-authored-by: Masuri <psh0258@gmail.com> Co-authored-by: LemonPi314 <49930425+LemonPi314@users.noreply.github.com> Co-authored-by: Gert Driesen <gertdriesen@msn.com> Co-authored-by: Rob Hague <rob.hague00@gmail.com> Co-authored-by: Rob Hague <rh@johnstreetcapital.com> Co-authored-by: Marius Thesing <marius.thesing@gmail.com> Co-authored-by: Dāvis Mošenkovs <davikovs@gmail.com> Co-authored-by: Dmitry Tsarevich <dimhotepus@users.noreply.github.com> Co-authored-by: Patrick Yates <114094360+patrick-yates-redgate@users.noreply.github.com>

IgorMilavec added 9 commits December 15, 2021 23:28

POC unit tests

7d5ccb8

Modify AppVeyor test script to only run net472 and net5.0

2a47c9e

Fix ScpClientTest_*.DisposeOnPipeStreamShouldBeInvokedOnce in modern …

ba7ecbb

…targets

Fix runtime and culture dependant tests. Should we test this at all?

81b3a16

Make ForwardedPortDynamic exception visible

be97986

Fix PipeStream_Close_BlockingWrite synchronization

f91c5f1

Removed CountdownEventTest for FEATURE_THREAD_COUNTDOWNEVENT

8c66267

Remove Thread.Abort()

5304296

Fix another runtime dependant string

a7a9474

IgorMilavec added 7 commits December 17, 2021 13:28

Raise AppVeyor number of ports to avoid dynamic port exhaustion

de9faec

Fix previous "speeedup" of ChannelForwardedTcpipTest_Dispose_SessionI…

5bc16c8

…sConnectedAndChannelIsOpen

Speedup tests

36b751b

Ignore SocketError.TryAgain when expecting SocketError.HostNotFound

362910f

Better ObjectDisposedHandling in AsyncSocketListener

c1a657a

Handle SocketError.ConnectionAborted in ForwardedPortDynamic

bae6c54

Rename test to match implementation

48e1af3

Fix BaseClientTest_Connected_KeepAliveInterval_NotNegativeOne timing

f0a8f5f

IgorMilavec added 5 commits December 17, 2021 21:04

Set C# 7.3 in Tests.csproj to limit intellisense's suggestions under …

382649b

…different targets

Add SftpClientTest.*Async

07c1535

Add SftpFileStreamTest_OpenAsync_*

0030b35

Add SftpFileStreamTest_WriteAsync_*

2fbdb46

Add SftpFileStreamTest_ReadAsync_*

3547504

IgorMilavec marked this pull request as ready for review December 22, 2021 18:19

drieseng requested changes Feb 11, 2022

View reviewed changes

Remove unrelated changes

3506707

IgorMilavec added 2 commits February 12, 2022 23:48

Align AppVeyor script with Test project target frameworks

9f45e7f

Revert unrelated changes

a53f35b

drieseng approved these changes Feb 15, 2022

View reviewed changes

drieseng merged commit 4dfc126 into sshnet:develop Feb 15, 2022

IgorMilavec added this to the vNext milestone Feb 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add unit tests for task-based asynchronous API #906

Add unit tests for task-based asynchronous API #906

IgorMilavec commented Dec 15, 2021

IgorMilavec commented Dec 17, 2021

zybexXL commented Dec 17, 2021 •

edited

Loading

zybexXL commented Dec 17, 2021

IgorMilavec commented Dec 17, 2021

IgorMilavec commented Feb 10, 2022

drieseng left a comment

drieseng Feb 11, 2022

IgorMilavec Feb 11, 2022

drieseng Feb 12, 2022

drieseng Feb 12, 2022

drieseng Feb 11, 2022

IgorMilavec Feb 11, 2022

drieseng Feb 11, 2022

drieseng Feb 11, 2022

IgorMilavec Feb 11, 2022

drieseng Feb 11, 2022

drieseng Feb 11, 2022

drieseng Feb 11, 2022

drieseng Feb 11, 2022

drieseng Feb 11, 2022

drieseng Feb 11, 2022

IgorMilavec commented Feb 14, 2022

drieseng Feb 12, 2022

drieseng Feb 12, 2022

drieseng Feb 12, 2022

drieseng Feb 12, 2022

drieseng Feb 12, 2022

IgorMilavec commented Feb 15, 2022

drieseng commented Feb 16, 2022


		vstest.console /logger:Appveyor src\Renci.SshNet.Tests\bin\Debug\net35\Renci.SshNet.Tests.dll /TestCaseFilter:"TestCategory!=integration&TestCategory!=LongRunning"

Add unit tests for task-based asynchronous API #906

Add unit tests for task-based asynchronous API #906

Conversation

IgorMilavec commented Dec 15, 2021

IgorMilavec commented Dec 17, 2021

zybexXL commented Dec 17, 2021 • edited Loading

zybexXL commented Dec 17, 2021

IgorMilavec commented Dec 17, 2021

IgorMilavec commented Feb 10, 2022

drieseng left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IgorMilavec commented Feb 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IgorMilavec commented Feb 15, 2022

drieseng commented Feb 16, 2022

zybexXL commented Dec 17, 2021 •

edited

Loading