-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Updates to support Sitecore 9.x #209
Comments
Hi @sc-alistairdeneys! Thanks for your input! Versioning approach looks good to me. Regarding the migration. I'd love to do so but it seems it requires some additional research. Now there is a custom ConfigReader which performs some vital initial configurations. It's like an entry point to the lib! Sounds weird but it did the job for many years and without it nothing works :). And it stops working in SDK projects. Maybe I overlooked smth, but for now that's a stopper. |
My initial researched didn't show any issues; with an SDK format project everything was still working fine, including all the tests. I'll prep the PR and you can validate @sshushliapin. |
To continue this conversation, will you be supporting 9.3? |
My initial reaction was to say "yes" for 9.3 support, but then I'm wondering whether we should sit back and see if it's necessary. The abstractions in Sitecore have got a lot better, to the point that FakeDB shouldn't be required for unit testing on later versions of Sitecore. What do you think @sshushliapin? I'll continue with adding the 9.x support (looks to be working locally, just need time to check fully) up until version 9.2. |
Yes, it is not required anymore. TBH, I haven't used FakeDb for the past two years... I do not plan any further development but if it's possible to make it 9.2/9.3 compatible and it will work, then, of course, I'm ready to support this. |
we are using Sitecore 9.2 and using Fake db in our project. any plans of releasing the compatible version of it or we have to re-write the test cases, please confirm |
I'd like to submit some contributions to add support for the 9.x Sitecore versions. Unfortunately there have been some breaking changes in the APIs which mean we'll need to handle each major Sitecore version differently.
Looking at the v2 branch, it would appear support for the older Sitecore versions has been removed, as would be necessary to get the library building. Therefore, I propose we increment the major version of FakeDB as necessary to add support for each of the Sitecore 9.x versions. Something like:
In addition to the versioning changes, I'd also like to make a few changes to make the project easier to work with:
I intend to make these contributions myself.
Any concerns with this proposal?
The text was updated successfully, but these errors were encountered: