Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR#431 breaks connecting to Python <=3.5 hosts. #503

Closed
slashdd opened this issue Aug 11, 2020 · 0 comments · Fixed by #507
Closed

PR#431 breaks connecting to Python <=3.5 hosts. #503

slashdd opened this issue Aug 11, 2020 · 0 comments · Fixed by #507

Comments

@slashdd
Copy link

slashdd commented Aug 11, 2020

#431 breaks connecting to Python <=3.5 hosts.

Even if those python versions are (or near to) EOL, I think it is reasonable to say that one could use shuttle to log on a remote host that has a no longer supported python 3 versions.

Would upstream consider adding a backward compatible patch for this use case ?

Ubuntu discussion bug:
https://launchpad.net/bugs/1873368

ddstreet pushed a commit to ddstreet/sshuttle that referenced this issue Aug 15, 2020
drjbarker added a commit to drjbarker/sshuttle that referenced this issue Aug 28, 2020
Fixes  sshuttle#469. We replace python3 exclusive code with a check for python3 and a compatibility fix. Note that the switch from os.set_nonblocking to fcntl.fcntl in 98d052d (fixing sshuttle#503) also fixes python2 compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant