Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate sample name to 128 characters #427

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

kyungeonchoi
Copy link
Contributor

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.75%. Comparing base (8d44977) to head (14b7e2e).
Report is 5 commits behind head on 3.0_develop.

Additional details and impacted files
@@               Coverage Diff               @@
##           3.0_develop     #427      +/-   ##
===============================================
+ Coverage        80.62%   80.75%   +0.12%     
===============================================
  Files               26       26              
  Lines             1342     1351       +9     
===============================================
+ Hits              1082     1091       +9     
  Misses             260      260              
Flag Coverage Δ
unittests 80.75% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

servicex/databinder_models.py Outdated Show resolved Hide resolved
Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@BenGalewsky BenGalewsky merged commit 9940a9c into 3.0_develop Aug 27, 2024
34 checks passed
@BenGalewsky BenGalewsky deleted the max_length_sample_name branch August 27, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants