New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add New Dom Crawler Version #52

Open

rbaskam wants to merge 1 commit into ssnepenthe:master from rbaskam:feature/allow-newer-dom-crawler

rbaskam commented Nov 15, 2023

Thanks for the package. Using it with a Laravel 8 Application and most packages are now requiring Dom Crawler 5.

Tested with BBC Good Food, the default one in your example and it brings back the same result. Any issues let me know.

Thanks again.


          Add New Dom Crawler Version

8ef25f7

Owner

ssnepenthe commented Nov 15, 2023

Thanks for the PR!

It looks like dom-crawler v5 started normalizing whitespace in the text method, and this is breaking some of our tests.

Can you go back through and update ->text() calls to ->text(null, false) to fix this?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet