Adding block support to keep API compatibility with stdlib Logger #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blocks are only evaluated when the level of the logger is high enough. This is useful when generating the log message is rather expensive. The if any non-nil message is give that will always take precedence over the block.
|
LGTM |
|
@martonpe could you please make a release and push it to rubygems? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
Adds support for blocks.
Fixes the executables path so the
bindirectory is kept for development purposes and theexedirectory is for gem executables. At the moment we don't have any.Adds @tmichel to authors.
Add binstubs for rspec and rake. No more
bundle exec rake ...orbundle exec rspec