Convert string for fields marked as TIMESTAMP to Date #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1e5a527 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c-st
force-pushed
the
convert-timestamp-to-date
branch
from
bf90477
to
1e5a527
Compare
KennethWussmann
approved these changes
Jul 28, 2023
|
Looks like this one has been approved. Any reason it's not yet been merged? |
|
My approval doesn't count. It needs a maintainer. |
|
Hi @thdxr. It seems you have been merging previous PRs. Any chance you could have a look at this one, too? We're planning to use Kysely in a serverless environment but are somewhat blocked without this. |
|
Yeah let me ping Dax as well. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that when using a Kysely schema using
Date, writing and then reading the value would result in astringinstead of aDate. This is a different behaviour than what we observed with the built-in postgres-dialect (where TIMESTAMP fields are returned as Date).This adds a check for the field's
typeNameand performs the conversion toDateaccordingly.