fix: Astro greedy routes #3602
Merged
fix: Astro greedy routes #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 60bc30f The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #3601, preventing Astro route paths with very greedy RegEx values from capturing requests for static files by testing for a file extension in the CF Function and preventing rewrites if an extension is present.
Example routing before implementation of this PR:
/fr=>/fr/index.html/sitemap-index.xml=>/sitemap-index.xml/index.htmlExample routing after implementing this PR:
/fr=>/fr/index.htmlsitema-index.xml=>/sitemap-index.xml(unchanged)The only breaking change I can foresee with this change is if someone were to have implemented a false mime-type endpoint using the static rendering function (
/file.png=>/file.png/index.html) to serve an HTML page from a URL that appears to point to an asset. I can't see the value in doing this, so I'm assuming it's safe to abandon this functionality to resolve issues with i18n libraries.