Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astro-fix: prevent dead-end nodes from resulting in 404 #3720

Merged
merged 3 commits into from Mar 22, 2024

Conversation

bayssmekanique
Copy link
Contributor

Prevents route branches that don't have a matching final node from resulting in a null match when a viable match exists in a lower branch.

Works best when combined with Astro's experimental globalRoutePriority feature ( withastro/astro#9439) which avoids other common routing issues by prioritizing matching for plugins as well.

Resolves #3717

Copy link

changeset-bot bot commented Mar 21, 2024

🦋 Changeset detected

Latest commit: 931e907

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
sst Patch
@sst/console Patch
create-sst Patch
astro-sst Patch
svelte-kit-sst Patch
solid-start-sst Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fwang fwang merged commit e3c96d8 into sst:master Mar 22, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Mar 22, 2024
@bayssmekanique bayssmekanique deleted the fix/astro-route-bug branch March 24, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astro: Redirect routes cause some directories to fail matching on S3
2 participants