Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ingress to suit networking.k8s.io/v1 #72

Merged
merged 2 commits into from Jan 6, 2022

Conversation

SharkofMirkwood
Copy link
Contributor

I believe the latest versions of the chart are broken (1.1.0 and 1.0.1 both seem affected) due to backend in the ingress not matching the networking.k8s.io/v1 API spec; I've been receiving the following error on creating a release:

Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: [ValidationError(Ingress.spec.rules[0].http.paths[0].backend): unknown field "serviceName" in io.k8s.api.networking.v1.IngressBackend, ValidationError(Ingress.spec.rules[0].http.paths[0].backend): unknown field "servicePort" in io.k8s.api.networking.v1.IngressBackend]

See https://kubernetes.io/docs/concepts/services-networking/ingress/#the-ingress-resource and https://blog.hycorve.com/migrating-from-ingress-networking-k8s-io-v1beta1-to-v1/

I can't tell how you handle chart versioning here since the Chart.yaml hasn't been updated in 2 years, so I assume this is automated.

@sstarcher
Copy link
Owner

@SharkofMirkwood thanks and you were able to test this fix in your cluster?

@dirien
Copy link
Contributor

dirien commented Jan 5, 2022

May I add the point, to keep the chart a little bit downwards compatibel with using the template functions? I could help to add this, if its wanted ofc.

@sstarcher
Copy link
Owner

@dirien Since networking.k8s.io/v1beta1 is being removed in 1.22 and networking.k8s.io/v1 has been around for a while I don't know if we want to support clusters older than 1.19 as I don't believe they are supported by Kubernetes itself.

@sstarcher
Copy link
Owner

If someone can verify for me that this PR fixes the problem as listed and was tested I'll merge this and release a version.

@dirien
Copy link
Contributor

dirien commented Jan 6, 2022

@sstarcher,

works fine, here some screenshots:
image

image

Hope it helps

Deployed via local clone of the local repo
image

@sstarcher sstarcher merged commit 21b3d52 into sstarcher:master Jan 6, 2022
@sstarcher
Copy link
Owner

This should now be available as 1.1.1. The entire release is automated except for the docker image build... since docker hub stopped doing that for open source projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants