namespace icon classes to avoid style conflict

[simpixelated]

When using Twitter Bootstrap, I noticed one conflict with .blockquote, which breaks the button layout:

My suggestion is to namespace all of the icon classes, maybe with just icon- (e.g. icon-blockquote).

[KyleAMathews]

Or perhaps use CSS-modules
On Wed, Mar 9, 2016 at 2:59 PM Jordan Kohl notifications@github.com wrote:

When using Twitter Bootstrap, I noticed one conflict with .blockquote
http://v4-alpha.getbootstrap.com/content/reboot/#blockquote, which
breaks the button layout:
[image: screen shot 2016-03-09 at 2 56 25 pm]
https://cloud.githubusercontent.com/assets/838282/13653539/2330636a-e607-11e5-9199-539e5ffa746c.png

My suggestion is to namespace all of the icon classes, maybe with just
icon- (e.g. icon-bootstrap).

—
Reply to this email directly or view it on GitHub
#5.

[simpixelated]

@KyleAMathews agreed; I just don't know enough about CSS-modules to make a pull request -- but will look into it. Can it be added as a loader/build step with just Webpack?

[sstur]

Thanks @KyleAMathews. I am planning to move to CSS Modules soon (It's in the TODO in the readme). Will have created a separate issue to track that progress: #10

[KyleAMathews]

👍
On Wed, Mar 9, 2016 at 6:13 PM Simon Sturmer notifications@github.com
wrote:

Thanks @KyleAMathews https://github.com/KyleAMathews. I am planning to
move to CSS Modules soon (It's in the TODO in the readme). Will have
created a separate issue to track that progress: #10
#10

—
Reply to this email directly or view it on GitHub
#5 (comment).