-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
namespace icon classes to avoid style conflict #5
Comments
Or perhaps use CSS-modules
|
@KyleAMathews agreed; I just don't know enough about CSS-modules to make a pull request -- but will look into it. Can it be added as a loader/build step with just Webpack? |
Thanks @KyleAMathews. I am planning to move to CSS Modules soon (It's in the TODO in the readme). Will have created a separate issue to track that progress: #10 |
👍
|
When using Twitter Bootstrap, I noticed one conflict with .blockquote, which breaks the button layout:
![screen shot 2016-03-09 at 2 56 25 pm](https://cloud.githubusercontent.com/assets/838282/13653539/2330636a-e607-11e5-9199-539e5ffa746c.png)
My suggestion is to namespace all of the icon classes, maybe with just
icon-
(e.g.icon-blockquote
).The text was updated successfully, but these errors were encountered: