Allow to set customStyleMap on Editor #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. This PR looks good to me! |
| @@ -78,7 +79,7 @@ export default class RichTextEditor extends Component { | |||
| <Editor | |||
| {...otherProps} | |||
| blockStyleFn={getBlockStyle} | |||
| customStyleMap={styleMap} | |||
| customStyleMap={Object.assign(styleMap, customStyleMap)} | |||
There was a problem hiding this comment.
Oops, this mutates the global styleMap. I have to roll back this commit.
sstur
added a commit
that referenced
this pull request
Jun 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the internal
styleMapconst and thecustomStyleMapprop before setting it onEditorIn README it says:
Which is not totally right. I guess there's more props which is overridden by
rte,customStyleMapis just one of them.Thanks for an awesome draftjs wrapper.