Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use stage parameters before request parameters for chain pipelines #138

Closed
ssube opened this issue Feb 14, 2023 · 1 comment · Fixed by #178
Closed

use stage parameters before request parameters for chain pipelines #138

ssube opened this issue Feb 14, 2023 · 1 comment · Fixed by #178
Labels
status/fixed issues that have been fixed and released type/feature new features
Milestone
v0.8

Comments

@ssube
Copy link
Owner

ssube commented Feb 14, 2023

Add a method for chain pipeline stages to overwrite the request parameters with their stage-specific parameters and kwargs.
@ssube ssube added status/new issues that have not been confirmed yet type/feature new features labels Feb 14, 2023
@ssube ssube added this to the v0.8 milestone Feb 14, 2023
@ssube ssube added status/progress issues that are in progress and have a branch and removed status/new issues that have not been confirmed yet labels Feb 18, 2023
ssube added a commit that referenced this issue Feb 18, 2023
@ssube
feat(api): prefer chain stage parameters over request parameters (#138)
7b8ced0
@ssube ssube mentioned this issue Feb 18, 2023
Merged
@ssube
Copy link
Owner Author

ssube commented Feb 18, 2023

This has been mostly implemented, except for the stage_source and stage_mask args, but will need thorough testing.

@ssube ssube added status/fixed issues that have been fixed and released and removed status/progress issues that are in progress and have a branch labels Feb 19, 2023
@ssube ssube mentioned this issue Mar 5, 2023
Closed
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/fixed issues that have been fixed and released type/feature new features
Projects
None yet
Milestone
v0.8
Development

Successfully merging a pull request may close this issue.

prefer chain stage parameters over request parameters ssube/onnx-web
1 participant
@ssube