Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model_config not found error when conversion is interrupted part way through #222

Closed
ssube opened this issue Mar 7, 2023 · 0 comments · Fixed by #223
Closed

model_config not found error when conversion is interrupted part way through #222

ssube opened this issue Mar 7, 2023 · 0 comments · Fixed by #223
Labels
scope/convert status/fixed issues that have been fixed and released type/bug broken features
Milestone

Comments

@ssube
Copy link
Owner

ssube commented Mar 7, 2023

If a model is being converted and that conversion is interrupted, because of an error, keyboard interrupt, or disk space, it will leave an empty or mostly-empty model directory that shows up in the select menu, but produces an error if you try to use it.

When converting to a diffusers directory, the first thing created is the directory and the last thing created is the pretrained model_config.json file. The "has this model been converted" check uses the existence of the directory, but that does not guarantee that the model is loadable, which requires the config file.

Checking for both the directory and config file should fix this. If one or both do not exist, attempt to convert the model again.

@ssube ssube added status/new issues that have not been confirmed yet type/bug broken features labels Mar 7, 2023
@ssube ssube added this to the v0.8 milestone Mar 7, 2023
@ssube ssube mentioned this issue Mar 7, 2023
99 tasks
@ssube ssube added status/fixed issues that have been fixed and released and removed status/new issues that have not been confirmed yet labels Mar 8, 2023
@ssube ssube closed this as completed in #223 Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/convert status/fixed issues that have been fixed and released type/bug broken features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant