Skip to content

Commit

Permalink
* lib/webrick/server.rb (WEBrick::GenericServer#start):
Browse files Browse the repository at this point in the history
  partially revert r35315.

* test/webrick/test_server.rb (test_start_exception):
  received signal is delivered to the main thread, so it is needed to
  emulate it. patched by Eric Hodel. [ruby-core:44348] [Feature ruby#6236]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35323 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
  • Loading branch information
nurse committed Apr 14, 2012
1 parent e95f7ea commit c26ea74
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 6 deletions.
9 changes: 9 additions & 0 deletions ChangeLog
@@ -1,3 +1,12 @@
Sat Apr 14 10:45:18 2012 NARUSE, Yui <naruse@ruby-lang.org>

* lib/webrick/server.rb (WEBrick::GenericServer#start):
partially revert r35315.

* test/webrick/test_server.rb (test_start_exception):
received signal is delivered to the main thread, so it is needed to
emulate it. patched by Eric Hodel. [ruby-core:44348] [Feature #6236]

Sat Apr 14 09:35:45 2012 Eric Hodel <drbrain@segment7.net>

* variable.c (trace_ev): Removed "not reached" comment as this line is
Expand Down
8 changes: 4 additions & 4 deletions lib/webrick/server.rb
Expand Up @@ -133,12 +133,12 @@ def start(&block)
rescue Errno::EBADF, IOError => ex
# if the listening socket was closed in GenericServer#shutdown,
# IO::select raise it.
rescue Interrupt => ex # ^C
@logger.fatal ex
raise
rescue Exception => ex
rescue StandardError => ex
msg = "#{ex.class}: #{ex.message}\n\t#{ex.backtrace[0]}"
@logger.error msg
rescue Exception => ex
@logger.fatal ex
raise
end
end

Expand Down
4 changes: 2 additions & 2 deletions test/webrick/test_server.rb
Expand Up @@ -29,12 +29,12 @@ def test_start_exception
:StopCallback => Proc.new{ stopped += 1 },
}

e = assert_raises(Interrupt) do
e = assert_raises(SignalException) do
TestWEBrick.start_server(Echo, config) { |server, addr, port, log|
listener = server.listeners.first

def listener.accept
Process.kill(:INT, $$) # simulate ^C
raise SignalException, 'SIGTERM' # simulate signal in main thread
end

Thread.pass while server.status != :Running
Expand Down

0 comments on commit c26ea74

Please sign in to comment.