Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Architecture and design doc #40

Merged
merged 5 commits into from
Feb 21, 2022
Merged

Add Architecture and design doc #40

merged 5 commits into from
Feb 21, 2022

Conversation

yokawasa
Copy link
Contributor

@yokawasa yokawasa commented Feb 20, 2022 •
edited
Loading

Description

  • Add Architecture and design 7e94cfa
  • Add "Debug and Trace Gatling Load Testing" section in user guide ecb70b2
  • Add note(caution) on ConfigMap limitation to user guide 18fff1f

relevant issue

@yokawasa yokawasa requested review from a team February 21, 2022 02:07
ksudate
ksudate approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@ksudate ksudate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

yokochin0105
yokochin0105 approved these changes Feb 21, 2022
View reviewed changes
Copy link

@yokochin0105 yokochin0105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kayamin
kayamin approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@kayamin kayamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating documents. I commented some nits but as a whole it looks good to me 👍

docs/user-guide.md Outdated Show resolved Hide resolved
docs/architecture.md Outdated Show resolved Hide resolved
yokawasa and others added 2 commits February 21, 2022 12:06
@yokawasa @kayamin
Update docs/user-guide.md
fb2f0d2 
Co-authored-by: kayamin <ajh.shika829@gmail.com>
@yokawasa @kayamin
Update docs/architecture.md
067adfb 
Co-authored-by: kayamin <ajh.shika829@gmail.com>
@yokawasa
Copy link
Contributor Author

@kayamin @tmrekk121 @yokochin0105 thanks for the view! I'm merging this

@yokawasa yokawasa merged commit 85e6984 into main Feb 21, 2022
@yokawasa yokawasa deleted the update-docs branch February 21, 2022 03:13
@yokawasa yokawasa mentioned this pull request Feb 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayamin kayamin kayamin approved these changes

@ksudate ksudate ksudate approved these changes

@yokochin0105 yokochin0105 yokochin0105 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yokawasa @kayamin @ksudate @yokochin0105