This repository has been archived by the owner on May 4, 2024. It is now read-only.
Support TappingDevice::Device#stop_when
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The biggest issue `tapping_device` has is about performance. Because TracePoint literally taps every method call on every object if nothing disable it. So using `tapping_device` on large application with multiple tappings can be extremely slow or even hang your application. This commit tries to solve this issue by: 1. Adding `TappingDevice::Device#stop_when` to let users add stop condition. Once the block evaluation returns anything truthy, the tapping would be stopped. 2. Adding `tap_init`, `tap_on` and `tap_assoc` methods, which will first check if `stop_when` condition is provided and raise exception if not.
st0012
force-pushed
the
require-stop-condition
branch
from
e005c4a
to
1092ca6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest issue
tapping_devicehas is about performance. This is becauseTracePointliterally taps every method call on every object if nothing disables it. So usingtapping_deviceon a large application with multiple tappings can be extremely slow or even hang your application.This PR tries to solve this issue by:
Adding
TappingDevice::Device#stop_whento let users add stop condition. Once the block evaluation returns anything truthy, the tapping would be stopped.Adding
tap_init,tap_onandtap_assocmethods, which will first check ifstop_whencondition is provided and raise exception if not.